'Insufficient Funds' notification now will not show if balance will cover verified sites. #2208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonrsadler
force-pushed
the
ac-tips
branch
8 times, most recently
from
bc4f7fb
to
a84d5f3
Compare
jasonrsadler
force-pushed
the
ac-tips
branch
2 times, most recently
from
9145189
to
9901b73
Compare
jasonrsadler
force-pushed
the
ac-tips
branch
5 times, most recently
from
e6074e7
to
770e09b
Compare
jasonrsadler
force-pushed
the
ac-tips
branch
3 times, most recently
from
96083bd
to
2fcdb85
Compare
jasonrsadler
force-pushed
the
ac-tips
branch
5 times, most recently
from
7ebc1c7
to
471778d
Compare
NejcZdovc
reviewed
May 27, 2019
There was a problem hiding this comment.
Current call flow is like this:
- HasSufficientBalance (calls AC list)
- GetVerifiedAutoAmount (gets AC amount and calls recurring)
- GetVerifiedRecurringAmount (gets recurring amount and calls balance)
- OnFetchWalletProperties (return if sufficient balance)
I think this flow would be better
- HasSufficientBalance (calls balance)
- OnFetchWalletProperties (calls AC list)
- GetVerifiedAutoAmount (gets AC amount; return if not enough balance; calls recurring if enough balance)
- GetVerifiedRecurringAmount (gets recurring amount and return if sufficient balance)
With this approach we can exit sooner if we already know that AC is over the budget
NejcZdovc
reviewed
May 27, 2019
| this, _1, _2, total_reconcile_amount, callback)); | ||
| } | ||
|
|
||
| void BatContribution::OnFetchWalletProperties( |
There was a problem hiding this comment.
This one should be named more HasSufficientBalance specific as we will probably had more FetchWalletProperties calls. Maybe something like OnSufficientBalanceWallet?
NejcZdovc
reviewed
May 27, 2019
| } | ||
|
|
||
| // static | ||
| double BatContribution::GetAmountFromVerifiedRecurring( |
There was a problem hiding this comment.
Move it before OnFetchWalletProperties. This is how it's defined in .h
jasonrsadler
force-pushed
the
ac-tips
branch
4 times, most recently
from
6fb59c5
to
6977a45
Compare
|
Modified flow to exit if AC balance does not meet contribution requirements |
NejcZdovc
reviewed
May 28, 2019
| double total_reconcile_amount, | ||
| bool is_ac_list_empty, | ||
| ledger::HasSufficientBalanceToReconcileCallback callback) { | ||
| if (publisher_list.empty() && is_ac_list_empty) { |
There was a problem hiding this comment.
is_ac_list_empty is still needed? We now exit in AC if over, so if publisher_list is empty we know that we have enough funds
jasonrsadler
force-pushed
the
ac-tips
branch
2 times, most recently
from
2c2fe8a
to
0a0573c
Compare
jasonrsadler
force-pushed
the
ac-tips
branch
2 times, most recently
from
4dff4fa
to
7daedeb
Compare
NejcZdovc
approved these changes
May 29, 2019
This was referenced Jul 12, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#3707
Fixes brave/brave-browser#4104
Fixes brave/brave-browser#4090
brave-ui PR: brave/brave-ui#471
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security) onnpm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
-- --rewards=reconcile-interval=20(or some other value less than 4320 [3 days])Repeat the steps above with a different combination of verified and unverified sites and make sure notification does not show if the balance would cover the verified sites contribution.
Repeat the steps above using also a combination of verified and unverified recurring donations.
Verify that 'Insufficient Funds notifications are not shown if the combined reconcile amount of all verified publishers is under the wallet balance. Likewise make sure the notification is shown if the wallet balance is insufficient.
Reviewer Checklist: