Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A-C/Monthly Tips computation issue (leading to incorrect notifications) #3707

Closed
mandar-brave opened this issue Mar 13, 2019 · 1 comment · Fixed by brave/brave-core#2208
Closed

Comments

@mandar-brave
Copy link

For monthly recurring contributions, the only BAT that needs to be counted is;

a) for verified publishers in a-c
b) for verified publishers in Tip table

In any circumstance, the unverified pending BAT should not be counted for reconcile date contributions.

Issue: currently a lot of folks are getting incorrect notifications that they don't have sufficient funds for their monthly contribution when they do.

cc @NejcZdovc @jasonrsadler @LaurenWags @rebron

@mandar-brave mandar-brave added bug feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. labels Mar 13, 2019
jasonrsadler pushed a commit to brave/brave-core that referenced this issue Apr 13, 2019
Add verified tips calculation into notification

Add test for GetAmountFromVerifiedAuto

Fix lint

lint fixes

Adding tests

Combined tests to create WillTriggerNotification test

spacing

Updated methods to static
jasonrsadler pushed a commit to brave/brave-core that referenced this issue Apr 18, 2019
Add verified tips calculation into notification

Add test for GetAmountFromVerifiedAuto

Fix lint

lint fixes

Adding tests

Combined tests to create WillTriggerNotification test

spacing

Updated methods to static
jasonrsadler pushed a commit to brave/brave-core that referenced this issue Apr 24, 2019
Add verified tips calculation into notification

Add test for GetAmountFromVerifiedAuto

Fix lint

lint fixes

Adding tests

Combined tests to create WillTriggerNotification test

spacing

Updated methods to static

Updated logic and test case for no publishers and zero balance

lint
@LaurenWags
Copy link
Member

LaurenWags commented Jul 12, 2019

Verified passed with

Brave 0.67.108 Chromium: 75.0.3770.100 (Official Build) beta(64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Mac OS X

Verification passed on

Brave 0.67.108 Chromium: 75.0.3770.100 (Official Build) beta (64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Windows 10 OS Version 1803 (Build 17134.523)

Verification passed on

Brave 0.67.110 Chromium: 75.0.3770.100 (Official Build) beta(64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Ubuntu 18.04 LTS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants