This repository has been archived by the owner on May 13, 2024. It is now read-only.
Adds data-test-id to tableContribute row anchor #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NejcZdovc
reviewed
May 20, 2019
| @@ -95,7 +95,7 @@ export default class TableContribute extends React.PureComponent<Props, {}> { | |||
| content: [ | |||
| { | |||
| content: ( | |||
| <StyledLink href={row.url} target={'_blank'}> | |||
| <StyledLink href={row.url} target={'_blank'} data-test-id={row.profile.name}> | |||
There was a problem hiding this comment.
maybe a little bit more unique, data-test-id={'ac_link_' + row.profile.name}?
jasonrsadler
force-pushed
the
contribute-table-datatestid
branch
from
67948e1
to
c44109b
Compare
NejcZdovc
approved these changes
May 20, 2019
19 tasks
jasonrsadler
force-pushed
the
contribute-table-datatestid
branch
3 times, most recently
from
94e46f7
to
f56139e
Compare
jasonrsadler
force-pushed
the
contribute-table-datatestid
branch
from
f56139e
to
d06e47d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds data-test-id to tableContribute row anchor to identify row links for testing
Test plan
Link / storybook path to visual changes
Integration
Does this contain changes to src/components or src/
Does this contain changes to src/features for brave-core?