Remove region support for Ads as CDN now controls catalog for each region 0.64.x #2142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmancey
changed the title
kjozwiak
requested changes
Apr 2, 2019
There was a problem hiding this comment.
Before approving this into 0.64.x, we'll need to make sure the following has been checked/completed as per https://github.com/brave/brave-browser/wiki/Uplifting-a-pull-request#uplift-templates:
- Please ensure that the
jenkinsfailure was not caused by this specific PR - Please ensure that this PR is working under
0.65.x(nighty) before we start uplifting into0.64.x
3 tasks
kjozwiak
approved these changes
Apr 2, 2019
There was a problem hiding this comment.
Uplift to 0.64.x approved after the required checks have been completed as per the update to the description. Also deliberated with the @bsclifton @rebron and @srirambv 👍
Please make sure that all the appropriate labels are used and that the appropriate issue is moved into the correct milestone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uplift for #1983
Fixes brave/brave-browser#3752