-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove region support for Ads as CDN now controls catalog for each region #3752
Comments
Verification passed on
Verification PASSED on
Verificatoin passed on
|
@tmancey would it be possible to basically add something into the logging that specifies that the CDN check has failed? Right now, QA is basically reliant on the UI via #3967. However, #3967 is currently broken so there's no way for QA to check if ads are not appearing due to being in an incorrect region or something else might have regressed. If the UI breaks in future builds, QA won't be able to double check if the CDN check actually failed etc.. Having something within logging would be super helpful and useful. Thoughts? |
@kjozwiak Sure if you could raise a ticket and we can triage with Jimmy as once we generate the bundle from the catalog we can log information such as the amount of campaigns. Also we can log the IsRegionSupported call to show what region was detected. |
Thanks @tmancey 👍 For now, we can just take a look at the |
Remove region support for Ads including
--brave-ads-locale
command-line argument as CDN now controls catalog for each regionThe text was updated successfully, but these errors were encountered: