-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove region support for Ads as CDN now controls catalog for each region #1983
Conversation
@tmancey how can regular Joe like me from Slovenia test ads if local will be determinate via CDN and ads are not available here? The only thing that I can think of is VPN. |
@NejcZdovc Only way is using a VPN |
I am not seeing any ads on Linux when device region is set to Canada, and using a VPN(US node) still doesn't seem to trigger ads. @mbacchi mentioned in slack that he was able to see ad on Linux however when I try with/without VPN I am still not able to see any ads on Linux. When spoke to @tmancey on call he mentioned this PR fixes the issue of region and not seeing ads. @jsecretan we should probably get this reviewed soon and have it uplifted to dev. |
49adf02
to
76035b3
Compare
Enable hangouts extension to allow screen share
Enable hangouts extension to allow screen share
Enable hangouts extension to allow screen share
fixes brave/brave-browser#3752
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests
) onnpm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Test that Ads are shown by using a VPN to set your location to one of the supported regions. And that Ads are not shown when setting your location to one of the unsupported regions.
Reviewer Checklist: