Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Set outer bundle override to ensure locale/icu sets up correctly #20471

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

kylehickinson
Copy link
Collaborator

@kylehickinson kylehickinson commented Oct 10, 2023

Resolves brave/brave-browser#33554

Refs brave/brave-ios#8213

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@kylehickinson kylehickinson added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 labels Oct 10, 2023
@kylehickinson kylehickinson self-assigned this Oct 10, 2023
@kylehickinson kylehickinson requested a review from a team as a code owner October 10, 2023 20:12
@kylehickinson kylehickinson merged commit 1bb725c into master Oct 11, 2023
17 checks passed
@kylehickinson kylehickinson deleted the ios-locale-crash-fix branch October 11, 2023 13:52
@github-actions github-actions bot added this to the 1.61.x - Nightly milestone Oct 11, 2023
brave-builds added a commit that referenced this pull request Oct 11, 2023
brave-builds added a commit that referenced this pull request Oct 11, 2023
kjozwiak pushed a commit that referenced this pull request Oct 11, 2023
…y (uplift to 1.60.x) (#20489)

Uplift of #20471 (squashed) to beta
kjozwiak pushed a commit that referenced this pull request Oct 11, 2023
…y (uplift to 1.59.x) (#20490)

Uplift of #20471 (squashed) to release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iOS does not set up locale resource loading correctly for certain locales
3 participants