Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

App crashes on launch when using a language that Brave supports but Chromium/brave-core doesn't #8213

Closed
kylehickinson opened this issue Oct 10, 2023 · 2 comments

Comments

@kylehickinson
Copy link
Collaborator

kylehickinson commented Oct 10, 2023

Description:

Brave has its own set of localized languages that are independent from Chromium's list. When the app launches it loads the Chromium resource packs for the selected language the user is using, however there are languages that are supported by Brave but not Chromium such as pt_BR (Chromium only has pt and pt_PT). This fails to find load the resource pak since that language isn't localized and results in a failed CHECK

Steps to Reproduce

  1. Set language to Portuguese (Brazil) (should also crash with certain Korea/China language/region combos)
  2. Launch the app

Actual result:

Crashes

Expected result:

Fall back to Chromium supported languages and don't crash

Reproduces how often:

Always

Brave Version:

I believe we saw this crash log in 1.58, but tested and confirmed in 1.59+

@iccub
Copy link
Contributor

iccub commented Oct 16, 2023

Should be fixed as a part of latest core bump, please test using the STR

@Uni-verse
Copy link
Contributor

Uni-verse commented Oct 16, 2023

Verified on iPhone X running iOS 16.7 using version 1.58 (23.10.17.18)

Example Example Example
IMG_3588 IMG_3589 IMG_3590

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants