Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Set outer bundle override to ensure locale/icu sets up correctly (uplift to 1.58.x) #20491

Merged
merged 1 commit into from
Oct 11, 2023
Merged

[iOS] Set outer bundle override to ensure locale/icu sets up correctly (uplift to 1.58.x) #20491

merged 1 commit into from
Oct 11, 2023

Conversation

kylehickinson
Copy link
Collaborator

@kylehickinson kylehickinson commented Oct 11, 2023 •
edited by kjozwiak
Loading

Uplift of #20471
Resolves brave/brave-browser#33554

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@kylehickinson kylehickinson added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 labels Oct 11, 2023
@kylehickinson kylehickinson requested a review from a team as a code owner October 11, 2023 14:04
@kylehickinson kylehickinson self-assigned this Oct 11, 2023
@kjozwiak kjozwiak added this to the 1.58.x - Release #8 milestone Oct 11, 2023
kjozwiak
kjozwiak approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.58.x approved 👍

@kjozwiak kjozwiak merged commit 8b07ec4 into 1.58.x Oct 11, 2023
13 of 14 checks passed
@kjozwiak kjozwiak deleted the ios-locale-crash-fix-1.58.x branch October 11, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@kylehickinson kylehickinson

Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
Milestone
1.58.x - Release #8
Development

Successfully merging this pull request may close these issues.
2 participants
@kylehickinson @kjozwiak