Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Queue ad events until ads library is initialized. (uplift to 1.56.x) #19267

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Queue ad events until ads library is initialized. (uplift to 1.56.x) #19267

merged 1 commit into from
Jul 14, 2023

Conversation

aseren
Copy link
Collaborator

@aseren aseren commented Jul 12, 2023 •
edited by kjozwiak
Loading

Uplift of #19222
Resolves brave/brave-browser#31524

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@aseren aseren requested a review from a team as a code owner July 12, 2023 23:42
@aseren aseren changed the title Queue ad events until ads library is initialized. Queue ad events until ads library is initialized. (uplift to 1.56.x) Jul 12, 2023
@aseren aseren force-pushed the pr19222_issues/31524_1.56.x branch from 0a5ce04 to 73e78c9 Compare July 13, 2023 17:11
@aseren aseren requested a review from kylehickinson July 13, 2023 17:16
@aseren aseren force-pushed the pr19222_issues/31524_1.56.x branch from 73e78c9 to 75773f3 Compare July 13, 2023 18:21
LaurenWags
LaurenWags approved these changes Jul 14, 2023
View reviewed changes
Copy link
Member

@LaurenWags LaurenWags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift to 1.56.x is approved 👍🏻 QA will verify this on iOS with associated iOS issue brave/brave-ios#7728.

@LaurenWags LaurenWags merged commit c4e95a4 into 1.56.x Jul 14, 2023
@LaurenWags LaurenWags deleted the pr19222_issues/31524_1.56.x branch July 14, 2023 14:40
@github-actions github-actions bot added this to the 1.56.x - Release milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaurenWags LaurenWags LaurenWags approved these changes

@kylehickinson kylehickinson kylehickinson approved these changes

Assignees

@aseren aseren

Labels
None yet
Projects
None yet
Milestone
1.56.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@aseren @kylehickinson @LaurenWags