-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Queue ad events until ads library is initialized. #19222
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM++
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good, has this been tested yet in an iOS build?
yes, tested with version 1.56.x |
components/brave_ads/core/internal/ads_client_notifier_unittest.cc
Outdated
Show resolved
Hide resolved
components/brave_ads/core/internal/ads_client_notifier_unittest.cc
Outdated
Show resolved
Hide resolved
components/brave_ads/core/internal/ads_client_notifier_unittest.cc
Outdated
Show resolved
Hide resolved
components/brave_ads/core/internal/ads_client_notifier_queue.cc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (but see comments)
Resolves brave/brave-browser#31524
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Check that events are triggered for Brave Ads. Example of events:
Check that events are not triggered until Brave Ads are initialized