Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash in brave_ads::ConfirmationStateManager::GetUnblindedPaymentTokens #31524

Closed
aseren opened this issue Jul 7, 2023 · 1 comment · Fixed by brave/brave-core#19222
Closed
Assignees
Labels
crash feature/ads OS/iOS Fixes related to iOS browser functionality priority/P1 A very extremely bad problem. We might push a hotfix for it. QA/No release-notes/exclude

Comments

@aseren
Copy link

aseren commented Jul 7, 2023

Corresponding iOS issue - brave/brave-ios#7728

Version 1.53.102

BraveCore`brave_ads::UnblindedTokensPermissionRule::ShouldAllow:
  0x10bcfab98 <+0>: sub  sp, sp, #0x30
  0x10bcfab9c <+4>: stp  x20, x19, [sp, #0x10]
  0x10bcfaba0 <+8>: stp  x29, x30, [sp, #0x20]
  0x10bcfaba4 <+12>: add  x29, sp, #0x20
  0x10bcfaba8 <+16>: mov  x19, x8
  0x10bcfabac <+20>: bl   0x6291c0         ; brave_ads::ShouldRewardUser at account_util.cc:20
  0x10bcfabb0 <+24>: cbz  w0, 0x65ebc0       ; <+40> at unblinded_tokens_permission_rule.cc
  0x10bcfabb4 <+28>: bl   0x6b7d20         ; brave_ads::privacy::UnblindedTokenCount at unblinded_token_util.cc:80
-> 0x10bcfabb8 <+32>: cmp  x0, #0x9
  0x10bcfabbc <+36>: b.ls  0x65ebcc         ; <+52> [inlined] base::unexpected<char const*>::unexpected<char const (&) [40], 0>(char const (&) [40]) at expected.h:180:9
  0x10bcfabc0 <+40>: mov  w8, #0x1
  0x10bcfabc4 <+44>: str  x8, [x19, #0x18]
  0x10bcfabc8 <+48>: b   0x65ebe4         ; <+76> at unblinded_tokens_permission_rule.cc:34:1
  0x10bcfabcc <+52>: adrp  x8, 6654
  0x10bcfabd0 <+56>: add  x8, x8, #0x9d0      ; "You do not have enough unblinded tokens"
  0x10bcfabd4 <+60>: str  x8, [sp, #0x8]
  0x10bcfabd8 <+64>: add  x1, sp, #0x8
  0x10bcfabdc <+68>: mov  x0, x19
  0x10bcfabe0 <+72>: bl   0x5818b8         ; absl::variant_internal::VariantStateBase<absl::monostate, std::Cr::basic_string<char, std::Cr::char_traits<char>, std::Cr::allocator<char> >, std::Cr::basic_string<char, std::Cr::char_traits<char>, std::Cr::allocator<char> > >::VariantStateBase<2ul, char const*> at variant.h:1039
  0x10bcfabe4 <+76>: ldp  x29, x30, [sp, #0x20]
  0x10bcfabe8 <+80>: ldp  x20, x19, [sp, #0x10]
  0x10bcfabec <+84>: add  sp, sp, #0x30
  0x10bcfabf0 <+88>: ret
@aseren aseren added crash feature/ads OS/iOS Fixes related to iOS browser functionality labels Jul 7, 2023
@aseren aseren changed the title Crash in brave_ads::ConfirmationStateManager::GetUnblindedPaymentTokens() Crash in brave_ads::ConfirmationStateManager::GetUnblindedPaymentTokens Jul 7, 2023
@aseren aseren self-assigned this Jul 10, 2023
@aseren aseren added the priority/P1 A very extremely bad problem. We might push a hotfix for it. label Jul 10, 2023
@aseren aseren added this to the 1.56.x - Release milestone Jul 10, 2023
@LaurenWags LaurenWags added QA/No and removed QA/Yes labels Jul 14, 2023
@LaurenWags
Copy link
Member

Updating to QA/No for Desktop as per discussion with @aseren via https://bravesoftware.slack.com/archives/CHGKGMHDJ/p1689344825919449?thread_ts=1689207399.074299&cid=CHGKGMHDJ.

This issue will be verified on iOS. Corresponding iOS issue is brave/brave-ios#7728. I have also referenced the iOS test plan on the iOS issue to make it easier to find.

@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crash feature/ads OS/iOS Fixes related to iOS browser functionality priority/P1 A very extremely bad problem. We might push a hotfix for it. QA/No release-notes/exclude
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants