-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added BR flag image to vpn panel #18073
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
CI/storybook-url
Deploy storybook and provide a unique URL for each build
label
Apr 14, 2023
A Storybook has been deployed to preview UI for the latest push |
mkarolin
approved these changes
Apr 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GRD ++
bsclifton
approved these changes
Apr 14, 2023
brave-builds
added a commit
that referenced
this pull request
Apr 14, 2023
7 tasks
brave-builds
added a commit
that referenced
this pull request
Apr 14, 2023
7 tasks
Verified
|
Brave | 1.52.47 Chromium: 112.0.5615.121 (Official Build) nightly (x86_64) |
---|---|
Revision | 39cc4e45904ae9f1741c4fbaa866e629c96f2268-refs/branch-heads/5615_51@{#8} |
OS | macOS Version 11.7.6 (Build 20G1231) |
Steps:
- installed
1.52.47
- purchased, configured, and connected to
Brave VPN
- clicked on the
VPN
button on the toolbar - confirmed flag in
Brazil
entry - clicked
Connect
Confirmed the flag of Brazil
appeared in both places
Dark , server list |
Light , server list |
---|---|
Dark , connection status |
Light , connection status |
---|---|
kjozwiak
pushed a commit
that referenced
this pull request
Apr 17, 2023
Uplift of #18073 (squashed) to beta
kjozwiak
pushed a commit
that referenced
this pull request
Apr 17, 2023
Uplift of #18073 (squashed) to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix brave/brave-browser#29719
Filed f/u issue (brave/brave-browser#29727) - serve flag icon from leo.
Resolves
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: