Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Needs flag image for brazil region in vpn panel #29719

Closed
simonhong opened this issue Apr 14, 2023 · 6 comments · Fixed by brave/brave-core#18073
Closed

Needs flag image for brazil region in vpn panel #29719

simonhong opened this issue Apr 14, 2023 · 6 comments · Fixed by brave/brave-core#18073

Comments

@simonhong
Copy link
Member

image

@simonhong
Copy link
Member Author

cc @bsclifton @rebron It looks like guardian added new brazil region. Needs flag image for it.

@bsclifton
Copy link
Member

cc: @aguscruiz

@aguscruiz
Copy link

@simonhong we have a new set of flags from Leo, do you think you could use those? Or do you need me to prepare just the Brazil one for you?

@kjozwiak
Copy link
Member

The above requires 1.50.120 or higher for 1.50.x verification 👍

@LaurenWags
Copy link
Member

Verified with

Brave | 1.50.120 Chromium: 112.0.5615.121 (Official Build) (x86_64)
-- | --
Revision | 39cc4e45904ae9f1741c4fbaa866e629c96f2268-refs/branch-heads/5615_51@{#8}
OS | macOS Version 13.3.1 (Build 22E261)

Verified test plan from brave/brave-core#18073 (comment)

  1. installed 1.51.120
  2. purchased, configured, and connected to Brave VPN
  3. clicked on the VPN button on the toolbar
  4. confirmed flag in Brazil entry
  5. clicked Connect

Confirmed the flag of Brazil appeared in both places

Dark, server list Light, server list
Screenshot 2023-04-18 at 10 44 20 AM Screenshot 2023-04-18 at 10 42 02 AM
Dark, connection status Light, connection status
Screenshot 2023-04-18 at 10 41 37 AM Screenshot 2023-04-18 at 10 42 09 AM

@stephendonner
Copy link

Verified PASSED using

Brave 1.51.95 Chromium: 112.0.5615.121 (Official Build) beta (64-bit)
Revision 39cc4e45904ae9f1741c4fbaa866e629c96f2268-refs/branch-heads/5615_51@{#8}
OS Windows 10 Version 22H2 (Build 19045.2846)
Dark, server Dark, connection list
image (1) image
Light, server Light, connection list
image (2) image (3)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment