-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Brave VPN region data update #29728
Milestone
Comments
Merged
25 tasks
rebron
changed the title
Improve vpn region data update
Improve Brave VPN region data update
Apr 26, 2023
The above requires |
Verification
|
Brave | 1.51.110 Chromium: 113.0.5672.77 (Official Build) (x86_64) |
---|---|
Revision | c4236862955e005c2187105415ac4a2ecf86dff1-refs/branch-heads/5672_62@{#3} |
OS | macOS Version 11.7.6 (Build 20G1231) |
Steps:
- installed
1.51.110
- launched Brave using
--vmodule=*/vpn/*=2 --enable-logging=stderr --v=2
- purchased, configured, and connected to
Brave VPN
- shut down Brave (and disconnected from
Brave VPN
) - advanced system clock by 6 hours
- relaunched Brave
- checked the server-region list
- connected to various regions
Confirmed initial and subsequent retrievals of the supported region-list entries were downloaded successfully
US (West) |
Brazil |
Japan |
Singapore |
---|---|---|---|
Initial connection/download:
[11618:259:0503/122619.691845:VERBOSE2:brave_vpn_region_data_manager.cc(263)] FetchRegionDataIfNeeded : Start fetching region data
[11625:19715:0503/122619.692017:VERBOSE1:network_delegate.cc(35)] NetworkDelegate::NotifyBeforeURLRequest: https://connect-api.guardianapp.com/api/v1/servers/all-server-regions
After 5 hours:
[11720:259:0503/182741.174268:VERBOSE2:brave_vpn_region_data_manager.cc(300)] ParseAndCacheRegionList : has regionlist: 1
[11720:259:0503/182741.174307:VERBOSE2:brave_vpn_region_data_manager.cc(215)] LoadCachedRegionData : Loaded cached region list
[11720:28675:0503/182741.174324:VERBOSE1:command_storage_backend.cc(852)] Current session files:
[11720:259:0503/182741.174388:VERBOSE2:brave_vpn_service.cc(621)] Schedule subscriber credential fetching after 49262.8 s
[11720:259:0503/182741.174974:VERBOSE2:brave_vpn_region_data_manager.cc(263)] FetchRegionDataIfNeeded : Start fetching region data
[11720:259:0503/182741.174974:VERBOSE2:brave_vpn_region_data_manager.cc(263)] FetchRegionDataIfNeeded : Start fetching region data
[11720:259:0503/182741.175299:VERBOSE1:profile_manager.cc(1286)] AddKeepAlive(Default, kBrowserWindow). keep_alives=[kBrowserWindow (2)]
[11729:20227:0503/182741.176130:VERBOSE1:network_delegate.cc(35)] NetworkDelegate::NotifyBeforeURLRequest: https://connect-api.guardianapp.com/api/v1/servers/all-server-regions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
When vpn region list is updated, browser should get latest one.
We have background update logic for it but we found that it's triggered 5h later after launching.
That means user should use more than 5h to get update.
We should try to update region data 5h later from the last update check.
It's difficult to have STR because region data is updated from guardian.
#29719 is another related issue.
Steps to Reproduce
Actual result:
Region data is not updated - BR region is not visible from vpn panel
Expected result:
Region data is updated - BR region is visible from vpn panel
Reproduces how often:
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
The text was updated successfully, but these errors were encountered: