Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serve vpn region flag from leo instead of using static image #29727

Closed
simonhong opened this issue Apr 14, 2023 · 1 comment · Fixed by brave/brave-core#18449
Closed

Serve vpn region flag from leo instead of using static image #29727

simonhong opened this issue Apr 14, 2023 · 1 comment · Fixed by brave/brave-core#18449
Assignees
@simonhong
Labels
feature/vpn OS/Desktop QA Pass-macOS QA/Yes release-notes/exclude
Milestone
1.56.x - Release

Comments

@simonhong
Copy link
Member

simonhong commented Apr 14, 2023 •
edited
Loading

STR:

  1. Launch VPN and set purchased state
  2. Check main panel show flag images properly
@simonhong simonhong mentioned this issue Apr 14, 2023
Merged
25 tasks
@simonhong simonhong self-assigned this May 11, 2023
@simonhong simonhong mentioned this issue May 11, 2023
Merged
25 tasks
simonhong added a commit to brave/brave-core that referenced this issue May 22, 2023
@simonhong
Use flag images from leo for vpn panel
e8c6361 
fix brave/brave-browser#29727
@brave-builds brave-builds added this to the 1.53.x - Nightly milestone May 22, 2023
@stephendonner
Copy link

Verified PASSED using

Brave 1.53.67 Chromium: 114.0.5735.53 (Official Build) beta (x86_64)
Revision c499d7ea22c8b2dba278465a5df7b86a8efa4e64-refs/branch-heads/5735@{#970}
OS macOS Version 11.7.7 (Build 20G1345)
example example example example
Screen Shot 2023-05-26 at 6 43 54 PM Screen Shot 2023-05-26 at 6 37 11 PM Screen Shot 2023-05-26 at 6 37 33 PM Screen Shot 2023-05-26 at 6 38 06 PM
example example example example
Screen Shot 2023-05-26 at 6 38 13 PM Screen Shot 2023-05-26 at 6 38 20 PM Screen Shot 2023-05-26 at 6 38 22 PM Screen Shot 2023-05-26 at 6 38 37 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
feature/vpn OS/Desktop QA Pass-macOS QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.56.x - Release
Development

Successfully merging a pull request may close this issue.

Use flag images from leo for vpn panel brave/brave-core
3 participants
@stephendonner @simonhong @brave-builds