Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block cookie consent changes 1.45.x (Uplift to 1.45.x) #15356

Merged
merged 3 commits into from
Oct 17, 2022
Merged

Block cookie consent changes 1.45.x (Uplift to 1.45.x) #15356

merged 3 commits into from
Oct 17, 2022

Conversation

deeppandya
Copy link
Contributor

@deeppandya deeppandya commented Oct 5, 2022 •
edited by kjozwiak
Loading

Uplift of #15063
Uplift of #15187
Uplift of #15354
Resolves brave/brave-browser#8974
Resolves brave/brave-browser#25568
Resolves brave/brave-browser#25811

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@deeppandya deeppandya added this to the 1.45.x - Beta milestone Oct 5, 2022
@deeppandya deeppandya requested a review from a team as a code owner October 5, 2022 14:45
@deeppandya deeppandya self-assigned this Oct 5, 2022
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Oct 5, 2022
This was referenced Oct 17, 2022
Closed
Merged
kjozwiak
kjozwiak approved these changes Oct 17, 2022
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.45.x approved 👍 QA has verified the PR on Nightly as per brave/brave-variations#377 (comment), #15187 (comment) & #15354 (comment).

@kjozwiak kjozwiak merged commit e330dfa into 1.45.x Oct 17, 2022
@kjozwiak kjozwiak deleted the block_cookie_consent_changes_1.45.x branch October 17, 2022 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@deeppandya deeppandya

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Milestone
1.45.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@deeppandya @kjozwiak @bbondy