Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dismiss outside touch android #15354

Merged
merged 1 commit into from
Oct 5, 2022
Merged

Conversation

deeppandya
Copy link
Contributor

Resolves brave/brave-browser#25811

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@deeppandya deeppandya added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Oct 5, 2022
@deeppandya deeppandya added this to the 1.46.x - Nightly milestone Oct 5, 2022
@deeppandya deeppandya self-assigned this Oct 5, 2022
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Copy link
Contributor

@tapanmodh tapanmodh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deeppandya deeppandya merged commit 0e07c4d into master Oct 5, 2022
@deeppandya deeppandya deleted the disable_outside_touch_android branch October 5, 2022 18:59
@kjozwiak
Copy link
Member

kjozwiak commented Oct 17, 2022

Verification PASSED on Samsung S10+ running Android 12 using the following build(s):

Brave | 1.46.64 Chromium: 107.0.5304.36 (Official Build) canary (32-bit)
--- | ---
Revision | 2f9c7a5a1fe357d87e9bc07c65cca9136b3651c5-refs/branch-heads/5304@{#671}
OS | Android 12; Build/SP1A.210812.016

Using some of the STR/Cases outlined via brave/brave-variations#377 (comment), went through the following:

  • downloaded/installed 1.46.64 Chromium: 107.0.5304.36
  • relaunched and ensured that BraveAdblockCookieListOptInStudy:Enabled via brave://version

Screenshot_20221017-165712_Brave - Nightly

Once the above was done/ensured that BraveAdblockCookieListOptInStudy:Enabled, went through the following:

  • ensured that the cookie consent panel/notification appears without any issues after visiting five different websites
  • ensured that the cookie consent panel/notification appears without issues when refreshing a single website five times
  • ensured that clicking on No Thanks doesn't enable the Easylist-Cookie List filter
    • checked via brave://adblock to ensure that the filter was disabled
    • checked and ensured that the Block cookie consent notices isn't enabled via the Brave Shields & privacy settings
  • ensured that clicking on Block cookie notices enables Easylist-Cookie List
    • checked via brave://adblock to ensure that the filter was enabled
    • checked and ensured that the Block cookie consent notices is enabled via the Brave Shields & privacy settings
  • ensured that the Block cookie consent notices isn't appearing when a user isn't apart of BraveAdblockCookieListOptInStudy
  • ensured that tapping outside of the cookie consent panel doesn't dismiss the panel unless a user makes a decision

Created brave/brave-browser#26078 which we'll need to get fixed before we can enable BraveAdblockCookieListOptInStudy on 1.45.x using Griffin.

Example of refreshing a single website five times

Screen_Recording_20221017_172124_Brave.-.Nightly.mp4

Example of loading five different websites

Screen_Recording_20221017_181240_Brave.-.Nightly.mp4

Example when enabling via the panel/notification

Example Example
Screenshot_20221017-172153_Brave - Nightly Screenshot_20221017-172246_Brave - Nightly

Example when tapping on No Thanks via the panel/notification

Example Example
Screenshot_20221017-172857_Brave - Nightly Screenshot_20221017-172918_Brave - Nightly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable dismiss cookie consent dialog on outside click
4 participants