Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block cookie consent dialog android #15063

Merged
merged 10 commits into from
Sep 22, 2022
Merged

Conversation

deeppandya
Copy link
Contributor

@deeppandya deeppandya commented Sep 12, 2022

Resolves brave/brave-browser#8974

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Please reach out to @deeppandya for more details

@github-actions github-actions bot added the potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false label Sep 12, 2022
@deeppandya deeppandya changed the title Block cookie consent dialog android [WIP]Block cookie consent dialog android Sep 12, 2022
@deeppandya deeppandya force-pushed the cookie_consent_dialog_android branch 3 times, most recently from eeb5824 to a380e5b Compare September 20, 2022 05:44
@deeppandya deeppandya marked this pull request as ready for review September 20, 2022 05:48
@deeppandya deeppandya force-pushed the cookie_consent_dialog_android branch from a380e5b to ac7d3ae Compare September 20, 2022 05:48
@deeppandya deeppandya added this to the 1.45.x - Nightly milestone Sep 20, 2022
@deeppandya deeppandya changed the title [WIP]Block cookie consent dialog android Block cookie consent dialog android Sep 20, 2022
@deeppandya deeppandya force-pushed the cookie_consent_dialog_android branch from e64d47a to 3b34a5e Compare September 20, 2022 22:21
static jint
JNI_CookieListOptInServiceFactory_GetInterfaceToCookieListOptInService(
JNIEnv* env) {
auto* profile = ProfileManager::GetActiveUserProfile();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deeppandya deeppandya force-pushed the cookie_consent_dialog_android branch from 3b34a5e to e9090b7 Compare September 21, 2022 21:59
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Copy link
Contributor

@sujitacharya2005 sujitacharya2005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deeppandya deeppandya merged commit 52e5e49 into master Sep 22, 2022
@deeppandya deeppandya deleted the cookie_consent_dialog_android branch September 22, 2022 03:22
deeppandya added a commit that referenced this pull request Oct 5, 2022
@kjozwiak
Copy link
Member

Verification PASSED on Pixel 6 running Android 13 using the following build(s):

Brave | 1.46.15 Chromium: 106.0.5249.65 (Official Build) canary (32-bit)
--- | ---
Revision | 3269dc3633cdd2ab94546fdbe54962e45b17a6e0-refs/branch-heads/5249@{#580}
OS | Android 13; Build/T1B1.220819.006

Most of the QA was completed via brave/brave-variations#377 (comment) when we first enabled the above feature on Nightly. However, we are know uplifting the above into 1.45.x via #15356. QA also went through #15354 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] Cookie banner blocker
4 participants