-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block cookie consent dialog android #15063
Conversation
eeb5824
to
a380e5b
Compare
a380e5b
to
ac7d3ae
Compare
e64d47a
to
3b34a5e
Compare
static jint | ||
JNI_CookieListOptInServiceFactory_GetInterfaceToCookieListOptInService( | ||
JNIEnv* env) { | ||
auto* profile = ProfileManager::GetActiveUserProfile(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should pass a current profile from Android, check this
https://github.com/brave/brave-core/blob/master/browser/brave_wallet/android/keyring_service_factory_android.cc#L18
and this
https://github.com/brave/brave-core/blob/master/android/java/org/chromium/chrome/browser/crypto_wallet/KeyringServiceFactory.java#L36
android/java/org/chromium/chrome/browser/toolbar/top/BraveToolbarLayoutImpl.java
Show resolved
Hide resolved
android/java/org/chromium/chrome/browser/privacy/settings/BravePrivacySettings.java
Show resolved
Hide resolved
Add enableFilter native function ADd native function to check for the filter list
Remove native worker implementation
Resolve lint warnings
3b34a5e
to
e9090b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Block cookie consent dialog android
Verification PASSED on
Most of the QA was completed via brave/brave-variations#377 (comment) when we first enabled the above feature on |
Resolves brave/brave-browser#8974
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Please reach out to @deeppandya for more details