Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide side panel option from settings (uplift to 1.44.x) #15282

Merged

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Sep 29, 2022

Uplift of #15270
fix brave/brave-browser#25689

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner September 29, 2022 13:54
@brave-builds brave-builds self-assigned this Sep 29, 2022
@brave-builds brave-builds added this to the 1.44.x - Release #2 milestone Sep 29, 2022
@simonhong simonhong self-assigned this Sep 29, 2022
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.44.x approved 👍 QA has verified the PR on Nightly as per #15270 (comment).

@kjozwiak kjozwiak merged commit b0b5eaa into 1.44.x Sep 30, 2022
@kjozwiak kjozwiak deleted the pr15270_hide_side_panel_option_from_settings_1.44.x branch September 30, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants