Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide side panel option from settings (uplift to 1.44.x) #15282

Merged
merged 1 commit into from
Sep 30, 2022
Merged

Hide side panel option from settings (uplift to 1.44.x) #15282

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions browser/ui/webui/settings/brave_settings_localized_strings_provider.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -637,6 +637,11 @@ void BraveAddLocalizedStrings(content::WebUIDataSource* html_source,
BravePrivacyHandler::AddLoadTimeData(html_source, profile);
BraveAddSyncStrings(html_source);

// Hide side panel option for showing left or right side.
// TODO(simonhong): Delete this when we can show sidebar on left.
// https://github.com/brave/brave-browser/issues/25332
html_source->AddBoolean("showSidePanelOptions", false);

// Load time data for brave://settings/extensions
html_source->AddBoolean(
"signInAllowedOnNextStartupInitialValue",
Expand Down