Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide side panel option from settings #15270

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Sep 29, 2022

fix brave/brave-browser#25689

Hide this option untill we can show sidebar on left side.

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Load brave://settings/appearance
  2. Check Side panel option is not visible

fix brave/brave-browser#25689

Hide this option untill we can show sidebar on left side.
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@simonhong simonhong merged commit 75d33a1 into master Sep 29, 2022
@simonhong simonhong deleted the hide_side_panel_option_from_settings branch September 29, 2022 13:51
@simonhong simonhong added this to the 1.46.x - Nightly milestone Sep 29, 2022
brave-builds pushed a commit that referenced this pull request Sep 29, 2022
brave-builds pushed a commit that referenced this pull request Sep 29, 2022
@kjozwiak
Copy link
Member

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.46.24 Chromium: 106.0.5249.65 (Official Build) nightly (64-bit)
-- | --
Revision | 3269dc3633cdd2ab94546fdbe54962e45b17a6e0-refs/branch-heads/5249@{#580}
OS | Windows 11 Version 22H2 (Build 22621.521)

Went through the STR/Cases outlined via #15270 (comment) as per the following:

1.46.21 Chromium: 106.0.5249.65 1.46.24 Chromium: 106.0.5249.65
old new

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide side panel option from settings appearance page
3 participants