Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add signing eip712 for hardware accounts #12265

Merged
merged 4 commits into from
Feb 18, 2022
Merged

Add signing eip712 for hardware accounts #12265

merged 4 commits into from
Feb 18, 2022

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Feb 15, 2022 •
edited
Loading

Resolves brave/brave-browser#18833

Added signing typed messages using Ledger and Trezor devices. Trezor is working only for Trezor Model One with Firmware 1.10.5 or higher

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@github-actions github-actions bot added CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/storybook-url Deploy storybook and provide a unique URL for each build labels Feb 15, 2022
@spylogsster spylogsster force-pushed the brave-18833 branch 7 times, most recently from 9a23e33 to dedb0e0 Compare February 15, 2022 17:03
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@spylogsster spylogsster force-pushed the brave-18833 branch 3 times, most recently from 6bf8dd2 to d44cc93 Compare February 16, 2022 11:14
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@spylogsster spylogsster force-pushed the brave-18833 branch 3 times, most recently from e3dd394 to b460f82 Compare February 16, 2022 15:12
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@spylogsster spylogsster force-pushed the brave-18833 branch 4 times, most recently from ba06968 to 2f027dd Compare February 16, 2022 17:10
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@spylogsster spylogsster requested a review from darkdh February 16, 2022 20:44
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@spylogsster spylogsster merged commit e8a688c into master Feb 18, 2022
@spylogsster spylogsster deleted the brave-18833 branch February 18, 2022 04:01
@spylogsster spylogsster added this to the 1.37.x - Nightly milestone Feb 18, 2022
@spylogsster spylogsster restored the brave-18833 branch February 18, 2022 15:20
spylogsster added a commit that referenced this pull request Feb 18, 2022
@spylogsster
Add signing eip712 for hardware accounts (#12265)
20b9c35 
(cherry picked from commit e8a688c)
@spylogsster spylogsster mentioned this pull request Feb 21, 2022
Merged
7 tasks
@srirambv
Copy link
Contributor

srirambv commented Feb 22, 2022 •
edited
Loading

Verification passed on

Brave 1.37.64 Chromium: 98.0.4758.102 (Official Build) nightly (64-bit)
Revision f60a827ddb87f1c403e0773751a5551d5856ac0-refs/branch-heads/4484@{#579}
OS Linux
  • Verified steps from PR
  • Verified able to sign messages on both Ledge and Trezor
Ledger Trezor
12265-Ledger.mp4
12265-Trezor.mp4

kjozwiak added a commit that referenced this pull request Feb 22, 2022
@kjozwiak
Merge pull request #12339 from brave/pr12265_uplift_1.36.x
8df945c 
(uplift to 1.36.x) Add signing eip712 for hardware accounts (#12265)
@srirambv srirambv mentioned this pull request Feb 23, 2022
Closed
@spylogsster spylogsster deleted the brave-18833 branch February 25, 2022 10:04
This was referenced Feb 25, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darkdh darkdh darkdh approved these changes

@onyb onyb Awaiting requested review from onyb

Assignees

@spylogsster spylogsster

Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Milestone
1.37.x - Release
Development

Successfully merging this pull request may close these issues.

Add signTypedData keyring support in the new wallet
4 participants
@spylogsster @brave-builds @srirambv @darkdh