Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add signTypedData keyring support in the new wallet #18833

Closed
spylogsster opened this issue Oct 18, 2021 · 2 comments · Fixed by brave/brave-core#12265
Closed

Add signTypedData keyring support in the new wallet #18833

spylogsster opened this issue Oct 18, 2021 · 2 comments · Fixed by brave/brave-core#12265
Assignees
@spylogsster
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Yes release-notes/include
Milestone
1.36.x - Release

Comments

@spylogsster
Copy link

Add support for the signTypedData method, same as #14705
@spylogsster spylogsster changed the title Add Ledger signTypedData keyring support in the new wallet #14705 Add Ledger signTypedData keyring support in the new wallet Oct 18, 2021
@bbondy bbondy added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P2 A bad problem. We might uplift this to the next planned release. labels Oct 21, 2021
@bbondy bbondy added the priority/P4 Planned work. We expect to get to it "soon". label Oct 29, 2021
@srirambv srirambv added the feature/web3/wallet Integrating Ethereum+ wallet support label Nov 3, 2021
@bbondy bbondy added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P4 Planned work. We expect to get to it "soon". labels Feb 10, 2022
@spylogsster spylogsster self-assigned this Feb 10, 2022
@spylogsster spylogsster changed the title Add Ledger signTypedData keyring support in the new wallet Add signTypedData keyring support in the new wallet Feb 16, 2022
@spylogsster spylogsster mentioned this issue Feb 16, 2022
Merged
25 tasks
@spylogsster spylogsster added this to the 1.37.x - Nightly milestone Feb 18, 2022
@spylogsster spylogsster mentioned this issue Feb 18, 2022
Merged
7 tasks
@kjozwiak
Copy link
Member

Will require 1.36.103 or higher.

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.36.106 Chromium: 99.0.4844.45 (Official Build) (arm64)
Revision edbc0b8343c7b10fddb0e1b4efb280b0f6e38cab-refs/branch-heads/4844@{#788}
OS macOS Version 12.1 (Build 21C52)
  • Verified test plan from brave/brave-core#12265
  • Verified able to sign messages using Ledger device
  • Verified Trezor throws error of min version when trying to sign message

Note: Trezor worked while verifying the uplift on Nightly as mentioned in brave/brave-core/#12265 (comment). This is failing on Linux as well now so logged #21338 for further investigation

Ledger Trezor
18833-Ledger.mov
18833-Trezor.mov

Checked with @spylogsster verification on one platform is sufficient

@srirambv srirambv mentioned this issue Feb 25, 2022
Closed
@srirambv srirambv mentioned this issue Feb 25, 2022
Closed
@LaurenWags LaurenWags mentioned this issue Mar 1, 2022
Closed
@bbondy bbondy added this to Web3 Mar 18, 2022
@bbondy bbondy moved this to Done in Web3 Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spylogsster spylogsster

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.36.x - Release
Development

Successfully merging a pull request may close this issue.

Add signing eip712 for hardware accounts brave/brave-core
4 participants
@bbondy @kjozwiak @spylogsster @srirambv