Upgrade from Chromium 98 to Chromium 99.

[mkarolin]

Upgrade from Chromium 98 to Chromium 99.

https://chromium.googlesource.com/chromium/src/+log/98.0.4758.102..99.0.4844.35/?pretty=fuller&n=10000

QA tests:
This is a major Chromium version bump, please do full passes.

Desktop Affected areas:

• AdBlock regional preferences settings
• Brave today preferences
• Handling of external URLs (including magnet)
• Wallet (correctly showing data, importing external wallet)
• Binance (correctly showing data)
• Sync works for newly created profiles
• Opening Guest and Tor windows from ☰ and context menus
• Component updater
• Extensions WebUI
• Speedreader
• Pages using brave:// scheme showing correct URL and loading
• Settings UI / History / Bookmarks - styling changes
• Check brave://flags page to make sure Brave features are listed

Android Affected areas:

• Stack overview mode removed (Retire stack layout UI for tabs overview mode #21005)
• New tab page UI
• Account Consistency (double check this still works AccountConsistencyMethod should default to disabled on Android #12319)
• Bottom toolbar icons
• Top toolbar UI
• Overview mode UI
• Private tab UI

[GeetaSarvadnya]

Verification PASSED on

Brave | 1.37.65 Chromium: 99.0.4844.35 (Official Build) nightly (64-bit)
-- | --
Revision | f60a827ddb87f1c403e07713751a5551d5856ac0-refs/branch-heads/4844@{#579}
OS | Windows 10 Version 21H2 (Build 19044.1526)

• Logged Settings animation is carried over from chrome #21256
• Logged Bookmarks folder layout color and style is getting changed upon mouse hover #21227
• Logged Browsing data list is empty in On Exit tab in brave://settings/clearBrowserData  #21225
• Logged Brave history tooltip icons are carried over from chrome #21259
• Logged Brave branded bookmarks folder icons are not shown in the bookmarks manager #21262
• Logged Clear data graphics shows the incognito icon in the PT and TOR tabs #21261
• Logged Speed reader icon is removed from the webpage #21273
• Logged When wallet is not yet created and user tries to reset the wallet, the wallet reset process should not continue #21274

Component updater_PASSED

• Testing is covered in Manual test run on Win x64 for 1.37.x - Nightly (Checking C99) #21196 (comment)

Handling of external URLs (including magnet)_PASSED

• Testing is covered in manual test run Manual test run on Win x64 for 1.37.x - Nightly (Checking C99) #21196

Sync works for newly created profiles_PASSED

• Testing is covered in the syn section in the manual test run Manual test run on Win x64 for 1.37.x - Nightly (Checking C99) #21196 (comment)

AdBlock regional preferences settings_PASSED

• Confirmed regional Adblock preferences are set when brave launched using --lang=PL, --lang=FR , --lang=CZE and --lang=de
• Encountered the issue Only one regional adblock filter list is selected in brave://adblock #20825

Opening Guest and Tor windows from ☰ and context menus_PASSED

• Confirmed context menu items work as expected
• Open a normal/[PT/TOR/Guest window and ensured hamburger menu items work as expected
• Confirmed click on each hamburger menu item redirects to the intended page

Context menu	Normal	PT	TOR	Guest

Brave today preferences_PASSED

• Confirmed click on Show Brave News shows the brave news feeds
• Confirmed content cards are loading the images correctly in feeds when the brave news feed is scrolled down
• Confirmed click on any image/link on news feed redirects to correct target link
• Confirmed images render properly on brave news feeds when any publisher is enabled/disabled via Sources
• Confirmed Brave News/feeds will not be shown when the Brave News switch is disabled
• Confirmed Brave News settings in Customize dashboard are retained after browser restart

Pages using brave:// scheme showing correct URL and loading_PASSED

• Confirmed brave:// scheme is showing up the correct URL and loads the correct page
• Verified all list of all the brave URLs from brave://about
  

Settings UI / History / Bookmarks - styling changes_PASSED

Settings

• Confirmed no new settings are added as part of C99 in brave://settings and advanced settings
• Confirmed are a few new settings added as part of Brave (e.g Sidebar, speed reader etc) in brave://settings
• Confirmed no new settings are added in brave://settings/content
• Confirmed no new settings are added in brave://settings/searchEngines
• Confirmed no new settings are added in brave://settings/passwords

History

• Conformed that history is shown for the visited websites in brave://history
• Confirmed that the history is shown from the imported browser history
  
• Encountered Brave history tooltip icons are carried over from chrome #21259

Bookmarks

• Confirmed bookmarks can be imported via 3 places (NTP, brave://settings/importData and Import bookmarks option from 3 dot menu in bookmarks manager)
• Confirmed bookmarks can be added/edited/deleted
• Confirmed imported bookmarks can be opened
• Encountered Bookmarks folder layout color and style is getting changed upon mouse hover #21227

Extensions WebUI_PASSED

• Confirmed Extensions WebUI works as expected
• Confirmed installed extensions are shown in brave://extensions/
• Confirmed installed extensions can be managed via manage extensions
• Enabled Allow in Private settings in manage extensions and ensured extension is shown in the Private tab
• Confirmed extension web UI is shown as expected in Private tan

Extensions	Extensions inspect

Extension web UI

Example	Example

_Extension web UI_Private Tab

Example	Example

Spreedreader_PASSED

• Confirmed enable speed-reader switch in brave://settings/appearance enables the speed reader mode on webpage/article
• Logged Speed reader icon is removed from the webpage #21273
• Confirmed speed-reader icon is shown in the URL bar
• Confirmed speed-reader icon is retained on the webpage upon browser restart
• Confirmed webpage/article is displayed in the reader mode when the speed-reader switch is enabled

Speed reader switch	article in reader mode

Brave flags_PASSED

• Compared release version with nightly channel and verified all the flags which starts with Brave and confirmed all the flags which are present in RC (1.35.x) are present in the nightly channel (1.37.x)
• One flag is missing #brave-adblock-redirect-url nightly which is expected as per Revert "Redirect URL support for adblock" brave-core#12064 (confirmed with @mkarolin )

Binance (verified by @srirambv)

• Verified Binance account is still logged in upon upgrade
• Verified Binance summary view state (show/hide balance) is retained upon upgrade
• Verified balance is updated every 30 sec
• Encountered <#21258> which seems to be an existing issue on 1.36.66 as well

Wallet (verified by @srirambv)

• Verified wallet account is retained upon upgrade
• Verified connecting Ledger wallet works fine and able to import accounts on both Live and Legacy
• Verified connecting Trezor wallet works fine and able to import accounts
• Verified able to submit transactions and approve/reject via hardware wallet
• More verification done via brave/brave-core#12265 (comment)

[Uni-verse]

Verification completed on 1.37.67, Chromium 99.0.4844.35

Device: Samsung Galaxy S21 | Android 12

PASS - Stack overview mode removed (#21005)
PASS - New tab page UI
PASS - Account Consistency (double check this still works #12319)
PASS - Bottom toolbar icons
PASS - Top toolbar UI
PASS - Overview mode UI
PASS - Private tab UI

Defects:

• Tab groups are reset after app upgrade #21248
• 

Removing tab from group after adding doesn't take affect if relaunching app #21278

[LaurenWags]

Changing to QA/No and release-notes/exclude as this is superseded by #21280