Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear data graphics shows the incognito icon in the PT and TOR tabs #21261

Closed
GeetaSarvadnya opened this issue Feb 23, 2022 · 5 comments · Fixed by brave/brave-core#12643
Closed

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Feb 23, 2022

Description

Clear data graphics shows the incognito icon in the PT and TOR tabs

Steps to Reproduce

  1. Clean profile 1.35.x or 1.37.x
  2. Open a PT/TOR window
  3. Open Hamburger menu
  4. Navigate to More tools->clear browsing data

Actual result:

Clear data graphics shows the incognito icon in the PT and TOR tabs
image

Expected result:

Looks like the graphic needs to be removed

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.37.65 Chromium: 99.0.4844.35 (Official Build) nightly (64-bit)
Revision f60a827ddb87f1c403e07713751a5551d5856ac0-refs/branch-heads/4844@{#579}
OS Windows 10 Version 21H2 (Build 19044.1526)
## Version/Channel Information:
  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @mkarolin @rebron

@GeetaSarvadnya
Copy link
Author

@rebron Looks like the graphic needs to be removed from brave as it's driven from chrome.

@LaurenWags
Copy link
Member

Reproduced with

Brave | 1.35.104 Chromium: 98.0.4758.109 (Official Build) (x86_64)
-- | --
Revision | 03268453da2c7409eb1ee934d97abfc6f3b45420-refs/branch-heads/4758@{#1179}
OS | macOS Version 12.2.1 (Build 21D62)

Screen Shot 2022-02-25 at 4 00 20 PM

@rebron rebron added the design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. label Mar 1, 2022
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Mar 4, 2022
@Sam-Sibley
Copy link

To clarify the expected result, do we expect this graphic to be removed entirely, so it is a text based dialog.
Or
Do we expect the Icongito icon to be removed from the graphic itself

@rebron rebron assigned mkarolin and unassigned Sam-Sibley Mar 17, 2022
@rebron rebron removed the design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. label Mar 17, 2022
mkarolin added a commit to brave/brave-core that referenced this issue Mar 17, 2022
Fixes brave/brave-browser#21261

Chromium change:

https://chromium.googlesource.com/chromium/src/+/bcd960054391a5379de3b47582c4b76a84f31d4d

commit bcd960054391a5379de3b47582c4b76a84f31d4d
Author: Rohit Agarwal <[email protected]>
Date:   Mon Jun 21 07:21:56 2021 +0000

    Add Incognito CBD dialog header art.

    This CL adds the header art to the incognito clear browsing data
    dialog.

    Screenshot darkmode: https://screenshot.googleplex.com/AYntUFjW4ekMVq8
    Screenshot lighmode: https://screenshot.googleplex.com/4Ppo7SKaWTYk4wV

    Bug: 1214196
@mkarolin mkarolin added this to the 1.38.x - Nightly milestone Mar 17, 2022
@kjozwiak
Copy link
Member

The above will require 1.37.99 or higher for verifications on 1.37.x

@GeetaSarvadnya
Copy link
Author

Verification PASSED on

Brave | 1.37.106 Chromium: 100.0.4896.46 (Official Build) (64-bit)
-- | --
Revision | 5ca33821b2211805855c77d334353d27c616a7ca-refs/branch-heads/4896@{#584}
OS | Windows 10 Version 21H2 (Build 19044.1586)

  • Verified the STR from the description and ensured the graphics is removed from the PT and TOR tab windows
Private window TOR window
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants