-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clear data graphics shows the incognito icon in the PT and TOR tabs #21261
Labels
branding
OS/Desktop
priority/P3
The next thing for us to work on. It'll ride the trains.
QA Pass-Win64
QA/Test-Plan-Specified
QA/Yes
release-notes/exclude
Milestone
Comments
@rebron Looks like the graphic needs to be removed from brave as it's driven from chrome. |
rebron
added
the
design/needs-mock-up
needs-mockup A feature which needs design mockup to be implemented.
label
Mar 1, 2022
rebron
added
the
priority/P3
The next thing for us to work on. It'll ride the trains.
label
Mar 4, 2022
To clarify the expected result, do we expect this graphic to be removed entirely, so it is a text based dialog. |
rebron
removed
the
design/needs-mock-up
needs-mockup A feature which needs design mockup to be implemented.
label
Mar 17, 2022
mkarolin
added a commit
to brave/brave-core
that referenced
this issue
Mar 17, 2022
Fixes brave/brave-browser#21261 Chromium change: https://chromium.googlesource.com/chromium/src/+/bcd960054391a5379de3b47582c4b76a84f31d4d commit bcd960054391a5379de3b47582c4b76a84f31d4d Author: Rohit Agarwal <[email protected]> Date: Mon Jun 21 07:21:56 2021 +0000 Add Incognito CBD dialog header art. This CL adds the header art to the incognito clear browsing data dialog. Screenshot darkmode: https://screenshot.googleplex.com/AYntUFjW4ekMVq8 Screenshot lighmode: https://screenshot.googleplex.com/4Ppo7SKaWTYk4wV Bug: 1214196
Merged
25 tasks
7 tasks
The above will require |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
branding
OS/Desktop
priority/P3
The next thing for us to work on. It'll ride the trains.
QA Pass-Win64
QA/Test-Plan-Specified
QA/Yes
release-notes/exclude
Description
Clear data graphics shows the incognito icon in the PT and TOR tabs
Steps to Reproduce
Actual result:
Clear data graphics shows the incognito icon in the PT and TOR tabs
Expected result:
Looks like the graphic needs to be removed
Reproduces how often:
Easy
Brave version (brave://version info)
Other Additional Information:
Miscellaneous Information:
cc: @brave/legacy_qa @mkarolin @rebron
The text was updated successfully, but these errors were encountered: