-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle multiple chains in BlockchainRegistry #11791
Conversation
77e4487
to
ac79901
Compare
A Storybook has been deployed to preview UI for the latest push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
@@ -715,7 +716,8 @@ void BraveWalletService::AddSuggestTokenRequest( | |||
request->token->is_erc721, chain_id); | |||
|
|||
if (!token && chain_id == mojom::kMainnetChainId) | |||
token = BlockchainRegistry::GetInstance()->GetTokenByContract(addr); | |||
token = BlockchainRegistry::GetInstance()->GetTokenByContract( | |||
mojom::kMainnetChainId, addr); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably not within this PR's scope, now that we'll have registry data for other chains, in a future PR we should query the registry using chain_id for other chains too and use it if found.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noted, thx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in rebase here 60036d2
3f78311
to
901678a
Compare
3a878ae
to
70cb2b9
Compare
A Storybook has been deployed to preview UI for the latest push |
70cb2b9
to
d7db399
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing multi-chain registry support forAddSuggestToken
.
A Storybook has been deployed to preview UI for the latest push |
d7db399
to
a283842
Compare
A Storybook has been deployed to preview UI for the latest push |
Resolves brave/brave-browser#20344
Resolves brave/brave-browser#20342
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: