Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle multiple chains in BlockchainRegistry #11791

Merged
merged 5 commits into from
Jan 13, 2022
Merged

Handle multiple chains in BlockchainRegistry #11791

merged 5 commits into from
Jan 13, 2022

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Jan 9, 2022

  • Makes the BlockchainRegistry functions take in a chain Id.
  • Parses 2 new token lists for which we don't have files for yet (but we will)
  • Adds a coingecko_id member to BlockchainToken. Front end code should use this for price data first if it's available.

Resolves brave/brave-browser#20344
Resolves brave/brave-browser#20342

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@bbondy bbondy requested a review from yrliou January 9, 2022 22:29
@bbondy bbondy requested a review from a team as a code owner January 9, 2022 22:29
@bbondy bbondy self-assigned this Jan 9, 2022
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Jan 9, 2022
@bbondy bbondy force-pushed the blockchain-registry-multi branch 2 times, most recently from 77e4487 to ac79901 Compare January 9, 2022 22:36
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

yrliou
yrliou approved these changes Jan 10, 2022
View reviewed changes
Copy link
Member

@yrliou yrliou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

components/brave_wallet/browser/brave_wallet_service.cc Outdated
@@ -715,7 +716,8 @@ void BraveWalletService::AddSuggestTokenRequest(
request->token->is_erc721, chain_id);

if (!token && chain_id == mojom::kMainnetChainId)
token = BlockchainRegistry::GetInstance()->GetTokenByContract(addr);
token = BlockchainRegistry::GetInstance()->GetTokenByContract(
mojom::kMainnetChainId, addr);
Copy link
Member

@yrliou yrliou Jan 10, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not within this PR's scope, now that we'll have registry data for other chains, in a future PR we should query the registry using chain_id for other chains too and use it if found.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noted, thx

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in rebase here 60036d2

@bbondy bbondy changed the title Blockchain registry multi Handle multiple chains in BlockchainRegistry Jan 11, 2022
@bbondy bbondy requested a review from a team as a code owner January 11, 2022 21:46
@bbondy bbondy force-pushed the blockchain-registry-multi branch 5 times, most recently from 3a878ae to 70cb2b9 Compare January 11, 2022 22:00
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

yrliou
yrliou approved these changes Jan 12, 2022
View reviewed changes
Copy link
Member

@yrliou yrliou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing multi-chain registry support forAddSuggestToken.

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@bbondy bbondy merged commit 36eff39 into master Jan 13, 2022
@bbondy bbondy deleted the blockchain-registry-multi branch January 13, 2022 00:25
@bbondy bbondy added this to the 1.36.x - Nightly milestone Jan 13, 2022
@onyb onyb mentioned this pull request Jan 13, 2022
Merged
25 tasks
@bbondy bbondy mentioned this pull request Jan 13, 2022
Closed
@Douglashdaniel Douglashdaniel mentioned this pull request Feb 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yrliou yrliou yrliou approved these changes

Assignees

@bbondy bbondy

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Milestone
1.36.x - Release
3 participants
@bbondy @brave-builds @yrliou