Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a coingeckoId to ERCToken to be used in the future in TokenRegistry #20344

Closed
bbondy opened this issue Jan 5, 2022 · 2 comments · Fixed by brave/brave-core#11791
Closed

Add a coingeckoId to ERCToken to be used in the future in TokenRegistry #20344

bbondy opened this issue Jan 5, 2022 · 2 comments · Fixed by brave/brave-core#11791
Assignees
@bbondy
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Milestone
1.36.x - Release

Comments

@bbondy
Copy link
Member

bbondy commented Jan 5, 2022

We should try to parse a coingeckoId in preparation for better multi chain lookups and 1-off fixes of wrong prices.
@bbondy bbondy added OS/Android Fixes related to Android browser functionality OS/Desktop labels Jan 5, 2022
@bbondy bbondy self-assigned this Jan 5, 2022
@bbondy bbondy changed the title Add a coingeckoId to ERCToken to be used in the future Add a coingeckoId to ERCToken to be used in the future in TokenRegistry Jan 5, 2022
@bbondy bbondy added feature/web3/wallet Integrating Ethereum+ wallet support priority/P3 The next thing for us to work on. It'll ride the trains. labels Jan 5, 2022
This was referenced Jan 5, 2022
Closed
Merged
@bbondy bbondy added this to the 1.36.x - Nightly milestone Jan 13, 2022
@onyb
Copy link
Member

onyb commented Jan 13, 2022

@bbondy Should we add a field for this to "Add custom asset"?

@bbondy
Copy link
Member Author

bbondy commented Jan 13, 2022

@bbondy Should we add a field for this to "Add custom asset"?

I think that'd be a good change, but pls post a new issue for that.

@onyb onyb mentioned this issue Jan 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bbondy bbondy

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.36.x - Release
Development

Successfully merging a pull request may close this issue.

Handle multiple chains in BlockchainRegistry brave/brave-core
2 participants
@bbondy @onyb