Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use coingeckoId to fetch prices whenever possible #20562

Closed
onyb opened this issue Jan 19, 2022 · 1 comment · Fixed by brave/brave-core#11900
Closed

Use coingeckoId to fetch prices whenever possible #20562

onyb opened this issue Jan 19, 2022 · 1 comment · Fixed by brave/brave-core#11900
Assignees
@onyb
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.36.x - Release

Comments

@onyb
Copy link
Member

onyb commented Jan 19, 2022

Following up on #20344, use the coingeckoId field in BlockchainToken type to fetch prices whenever defined. This is a more accurate way to fetch prices from Coingecko, compared to via symbol or contract address.

👉 QA steps: Please refer to the test plan in the linked PR.

Also related to #19740.
@onyb onyb self-assigned this Jan 19, 2022
@onyb onyb mentioned this issue Jan 19, 2022
Merged
25 tasks
@onyb onyb added this to the 1.36.x - Nightly milestone Jan 19, 2022
@Douglashdaniel Douglashdaniel mentioned this issue Jan 20, 2022
Closed
@srirambv
Copy link
Contributor

Brave 1.36.100 Chromium: 98.0.4758.102 (Official Build) beta (64-bit)
Revision 273bf7ac8c909cde36982d27f66f3c70846a3718-refs/branch-heads/4758@{#1151}
OS ☑️ Linux ☑️ Windows 11 Version Dev
(Build 22523.1000) 		☑️ macOS Version 12.0.1
(Build 21C52)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onyb onyb

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.36.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): use coingeckoId to fetch pricing data brave/brave-core
2 participants
@onyb @srirambv