Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom Crypto Assets (UFO) Added to Brave Wallet Shows Incorrect Market Data and Valuation #19740

Closed
divinIN3 opened this issue Nov 25, 2021 · 2 comments
Closed

Custom Crypto Assets (UFO) Added to Brave Wallet Shows Incorrect Market Data and Valuation #19740

divinIN3 opened this issue Nov 25, 2021 · 2 comments
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes needs-investigation A bug not 100% confirmed/fixed OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains.

Comments

@divinIN3
Copy link

Description

Added UFO crypto to Brave wallet

Steps to Reproduce

  1. Navigate to brave://wallet
  2. In Portfolio click + Visible Assets
  3. Add the UFO contract as custom token 0x249e38ea4102d0cf8264d3701f1a0e39c4f2dc3b
  4. Fill it details (I used 18 for decimal precision).
  5. Add

Actual result:

Shows fixed asset value of 0.41. The wallet shows the correct volume in my wallet but incorrect crypto price.

Expected result:

Display correct price and volume.

Reproduces how often:

Easily

Brave version (brave://version info)

Version 1.32.106 Chromium: 96.0.4664.45 (Official Build) (x86_64)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:
@srirambv srirambv added feature/web3/wallet Integrating Ethereum+ wallet support needs-investigation A bug not 100% confirmed/fixed labels Nov 26, 2021
@bbondy bbondy added priority/P2 A bad problem. We might uplift this to the next planned release. priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P2 A bad problem. We might uplift this to the next planned release. labels Nov 26, 2021
@onyb
Copy link
Member

onyb commented Dec 28, 2021

Could not reproduce this on 1.35.x (Nightly). I believe the incorrect price issue is fixed by brave/brave-core#11557. Going to uplift this fix to 1.34.x (Beta), so it's available in the Jan 4 2022 release.

Screen.Recording.2021-12-28.at.7.06.11.PM.mov

@onyb onyb mentioned this issue Jan 19, 2022
Closed
@bbondy bbondy added the front-end-change This task is a front end task and doesn't need any C++ changes label Mar 16, 2022
@HEagle18
Copy link

Confirmed with Onyb that we can now close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes needs-investigation A bug not 100% confirmed/fixed OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains.
Projects
Web3
Archived in project
Milestone
No milestone
Development

No branches or pull requests
5 participants
@bbondy @onyb @HEagle18 @srirambv @divinIN3