Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ChainID to the jsonRpcService getBalance Methods #20873

Closed
Douglashdaniel opened this issue Feb 3, 2022 · 3 comments · Fixed by brave/brave-core#12530
Closed

Add ChainID to the jsonRpcService getBalance Methods #20873

Douglashdaniel opened this issue Feb 3, 2022 · 3 comments · Fixed by brave/brave-core#12530
Assignees
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude

Comments

@Douglashdaniel
Copy link

Douglashdaniel commented Feb 3, 2022

Description

For multi chain support we will need to get balances for all visible tokens on each network.
Currently it will only return a balance of a token for the current Selected Network and is being handled in the backend.

If we could do something similar to what was implemented here brave/brave-core#11791
and allow to pass in a ChainID for the getBalance, getERC20TokenBalance and getERC721TokenBalance methods in the jsonRpcService.

Update: As discussed in slack we’ll modify those chain ids with “solana:” prefix to have no prefix. And then anywhere that asks for chain id we’ll also ask for CoinType. And for Filecoin we’ll just have chain_id as an empty string. Any API will have two required parameters, CoinType and then ChainId

@Douglashdaniel Douglashdaniel added feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop labels Feb 3, 2022
@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Feb 3, 2022
@darkdh
Copy link
Member

darkdh commented Feb 14, 2022

superseded by #21095

@darkdh darkdh closed this as completed Feb 14, 2022
@darkdh
Copy link
Member

darkdh commented Feb 14, 2022

reopen because we should be able to get balance for any token regardless of selected networks

@bbondy
Copy link
Member

bbondy commented Apr 26, 2022

Changing to release-notes/exclude because I don't think this is perceivable to a user of Release channel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants