Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve ads notification serving logging - 1.32.x #10613

Merged
merged 1 commit into from
Oct 25, 2021
Merged

improve ads notification serving logging - 1.32.x #10613

merged 1 commit into from
Oct 25, 2021

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Oct 20, 2021 •
edited by kjozwiak
Loading

Uplift of #10459
Resolves brave/brave-browser#18726

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@tmancey tmancey added this to the 1.32.x - Beta milestone Oct 20, 2021
@tmancey tmancey requested a review from a team October 20, 2021 15:08
@tmancey tmancey self-assigned this Oct 20, 2021
@tmancey tmancey force-pushed the issues/17542-1.32.x branch from cffdc83 to 1ed64b4 Compare October 20, 2021 16:14
@btlechowski btlechowski mentioned this pull request Oct 22, 2021
Closed
@btlechowski
Copy link

The code of this uplift is different to #10459. This uplift only contains a single line, that is just a log. This should be a separate PR, probably fixed under: brave/brave-browser#18726.

@tmancey
Copy link
Collaborator Author

tmancey commented Oct 22, 2021

The code of this uplift is different to #10459. This uplift only contains a single line, that is just a log. This should be a separate PR, probably fixed under: brave/brave-browser#18726.

This is the PR where this log was merged. It was agreed to remove all other code for this uplift and let the rest of the code ride the train. Thanks

@kjozwiak
Copy link
Member

Originally this PR was for brave/brave-browser#17542 which included the logging part. But as per #10613 (comment), everything was removed other than the logging component. Changed brave/brave-browser#17542 as the Resolved issue to brave/brave-browser#18726 via the summary.

@kjozwiak kjozwiak mentioned this pull request Oct 25, 2021
Closed
@kjozwiak kjozwiak changed the title Decouple Brave Ads serving pipeline - 1.32.x improve ads notification serving logging - 1.32.x Oct 25, 2021
kjozwiak
kjozwiak approved these changes Oct 25, 2021
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.32.x approved after deliberating with @brave/uplift-approvers.

@kjozwiak kjozwiak merged commit 47ea737 into 1.32.x Oct 25, 2021
@kjozwiak kjozwiak deleted the issues/17542-1.32.x branch October 25, 2021 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@tmancey tmancey

Labels
feature/ads
Projects
None yet
Milestone
1.32.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@tmancey @btlechowski @kjozwiak