Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple Brave Ads serving pipeline #10459

Merged
merged 1 commit into from
Oct 13, 2021
Merged

Decouple Brave Ads serving pipeline #10459

merged 1 commit into from
Oct 13, 2021

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Oct 11, 2021 •
edited
Loading

Resolves brave/brave-browser#17542

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Should be tested as part of #10580

@tmancey tmancey self-assigned this Oct 11, 2021
@tmancey tmancey force-pushed the issues/17542 branch 9 times, most recently from 5f0fb49 to 70005c1 Compare October 11, 2021 22:19
aseren
aseren reviewed Oct 12, 2021
View reviewed changes
...tive-ads/src/bat/ads/internal/eligible_ads/ad_notifications/eligible_ad_notifications_base.h

namespace ad_notifications {

class EligibleAdsBase {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should rename the file to eligable_ads_base.h to keep conformance between the filename and the class.

@tmancey tmancey force-pushed the issues/17542 branch 2 times, most recently from 3215b30 to a4fe96c Compare October 12, 2021 12:48
@tmancey tmancey force-pushed the issues/17542 branch 6 times, most recently from d7bbb1e to 5bfd739 Compare October 12, 2021 20:14
@tmancey tmancey merged commit a853842 into master Oct 13, 2021
@tmancey tmancey deleted the issues/17542 branch October 13, 2021 00:07
@tmancey tmancey added this to the 1.33.x - Nightly milestone Oct 13, 2021
@tmancey tmancey mentioned this pull request Oct 20, 2021
Merged
4 tasks
@kjozwiak kjozwiak mentioned this pull request Oct 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aseren aseren aseren approved these changes

@moritzhaller moritzhaller Awaiting requested review from moritzhaller

Assignees

@tmancey tmancey

Labels
feature/ads
Projects
None yet
Milestone
1.33.x - Release
Development

Successfully merging this pull request may close these issues.

Decouple Brave Ads serving pipeline
2 participants
@tmancey @aseren