Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple Brave Ads serving pipeline #17542

Closed
moritzhaller opened this issue Aug 18, 2021 · 4 comments · Fixed by brave/brave-core#10459
Closed

Decouple Brave Ads serving pipeline #17542

moritzhaller opened this issue Aug 18, 2021 · 4 comments · Fixed by brave/brave-core#10459
Assignees
@tmancey
Labels
dev-concern feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA/Yes release-notes/exclude
Milestone
1.33.x - Release

Comments

@moritzhaller
Copy link

Abstract ad serving into classes, instead of having conditional MaybeServeAdV1/MaybeServeAdV2/etc. logic
@tmancey tmancey removed the QA/No label Aug 23, 2021
@tmancey tmancey changed the title Refactor Brave Ads serving to use builder pattern for supporting variants Decouple Brave Ads serving pipeline Oct 8, 2021
@tmancey tmancey self-assigned this Oct 11, 2021
@tmancey tmancey added QA/Yes release-notes/exclude priority/P3 The next thing for us to work on. It'll ride the trains. labels Oct 11, 2021
This was referenced Oct 11, 2021
Merged
Closed
Closed
@tmancey tmancey added this to the 1.33.x - Nightly milestone Oct 13, 2021
@btlechowski
Copy link

This issue needs to uplifted to 1.32.x because it contains better logging for #18523.

@tmancey tmancey mentioned this issue Oct 20, 2021
Merged
4 tasks
@rebron
Copy link
Collaborator

rebron commented Nov 18, 2021

Updated milestone to 1.32.x.

@btlechowski
Copy link

@rebron There was confusion around this issue as we needed only logging to be uplifted. It was handled in #18726

This issue belongs to 1.33.x.

@btlechowski
Copy link

Verification passed on

Brave 1.33.83 Chromium: 96.0.4664.45 (Official Build) beta (64-bit)
Revision 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#10580
Verification done in https://github.com/brave/internal/issues/833

@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
dev-concern feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA/Yes release-notes/exclude
Projects
Ads
Archived in project
Milestone
1.33.x - Release
Development

Successfully merging a pull request may close this issue.

Decouple Brave Ads serving pipeline brave/brave-core
4 participants
@tmancey @moritzhaller @rebron @btlechowski