Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Make grammar consistent for titles and drop downs on brave://settings/shields #9975

Closed
6 tasks done
karenkliu opened this issue May 27, 2020 · 1 comment · Fixed by brave/brave-core#5684
Closed
6 tasks done

Comments

@karenkliu
Copy link

karenkliu commented May 27, 2020

Description

The grammar for titles and dropdown text on brave://settings/shields is inconsistent. Make them consistent with the following:

  • Change Block trackers & ads to Trackers & ads blocking
  • Make Trackers & ads blocking dropdown options: Aggressive Standard and Disabled
  • Change Cookies to Cookie blocking
  • Make Cookie blocking dropdown options: All Only cross-site and Disabled
  • Change Fingerprinting to Fingerprinting blocking
  • Make Fingerprinting blocking dropdown options: Strict, may break sites Standard and Disabled

Steps to Reproduce

  1. Go to brave://settings/shields

Designs

shields settings2

Reproduces how often:

Easily

Brave version (brave://version info)

Nightly

@kjozwiak
Copy link
Member

kjozwiak commented Jun 16, 2020

Verification PASSED on macOS 10.15.5 x64 using the following build:

Brave | 1.11.64 Chromium: 83.0.4103.97 (Official Build) dev (64-bit)
-- | --
Revision | 326d148b9655369b86498d9ecca39f63dd2bdd2d-refs/branch-heads/4103@{#657}
OS | macOS Version 10.15.5 (Build 19F101)
  • ensured that Block trackers & ads was changed to Trackers & ads blocking
  • ensured that the Trackers & ads blocking dropdown had the following entries
    • Aggressive, Standard & Disabled
  • ensured that Cookies was changed to Cookie blocking
  • ensured that the Cookie blocking dropdown had the following entries
    • All, Only cross-site & Disabled
  • ensured that Fingerprinting was changed to Fingerprinting blocking
  • ensured that the Fingerprinting blocking dropdown had the following entries
    • Strict, may break sites Standard & Disabled

Screen Shot 2020-06-15 at 11 16 38 PM

Screen Shot 2020-06-15 at 11 16 46 PM

Screen Shot 2020-06-15 at 11 16 55 PM

Verification passed on

Brave | 1.11.65 Chromium: 83.0.4103.97 (Official Build) dev (64-bit)
-- | --
Revision | 326d148b9655369b86498d9ecca39f63dd2bdd2d-refs/branch-heads/4103@{#657}
OS | Windows 10 OS Version 1903 (Build 18362.30)

  • ensured that Block trackers & ads was changed to Trackers & ads blocking
  • ensured that the Trackers & ads blocking dropdown had the following entries
    • Aggressive, Standard & Disabled
  • ensured that Cookies was changed to Cookie blocking
  • ensured that the Cookie blocking dropdown had the following entries
    • All, Only cross-site & Disabled
  • ensured that Fingerprinting was changed to Fingerprinting blocking
  • ensured that the Fingerprinting blocking dropdown had the following entries
    • Strict, may break sites Standard & Disabled
      image

image
image

Verification passed on

Brave 1.11.65 Chromium: 83.0.4103.97 (Official Build) dev (64-bit)
Revision 326d148b9655369b86498d9ecca39f63dd2bdd2d-refs/branch-heads/4103@{#657}
OS Ubuntu 18.04 LTS
  • ensured that Block trackers & ads was changed to Trackers & ads blocking
  • ensured that the Trackers & ads blocking dropdown had the following entries
    • Aggressive, Standard & Disabled
  • ensured that Cookies was changed to Cookie blocking
  • ensured that the Cookie blocking dropdown had the following entries
    • All, Only cross-site & Disabled
  • ensured that Fingerprinting was changed to Fingerprinting blocking
  • ensured that the Fingerprinting blocking dropdown had the following entries
    • Strict, may break sites Standard & Disabled

image
image
image

Logged #10324

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment