-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Desktop] Global and site-specific shield settings are not retained correctly after upgrade to 1.11.x #10303
Labels
Comments
GeetaSarvadnya
added
feature/global-settings
Settings at browser level independent of shields settings
feature/shields/fingerprint
The fingerprinting (aka: "device recognition") protection provided in Shields
QA/Yes
QA/Test-Plan-Specified
OS/Desktop
labels
Jun 16, 2020
Closed
6 tasks
GeetaSarvadnya
added
the
feature/shields/adblock
Blocking ads & trackers with Shields
label
Jun 17, 2020
The PR brave/brave-core#5879 may fix this issue also? |
32 tasks
this is not a bug, it isn intentional behavior per @pes10k |
Closing the issue as per the above comments. |
GeetaSarvadnya
removed
OS/Desktop
QA/Test-Plan-Specified
QA/Yes
feature/global-settings
Settings at browser level independent of shields settings
feature/shields/adblock
Blocking ads & trackers with Shields
feature/shields/fingerprint
The fingerprinting (aka: "device recognition") protection provided in Shields
labels
Jun 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Found while testing #9975
Global and site-specific shield settings are not retained correctly after upgrade to 1.11.x
Steps to Reproduce
Scenario 1:
Allow all cookies
Allow all fingerprinting
Disabled
instead ofStandard
as FP is allowed in step 4Allow all fingerprinting
instead ofFingerprinting blocked (standard)
Scenario 2:
Block cross-site trackers
Block cross-site trackers
are retained for buzzfeed.com (expected)Trackers and ad blocking
is set toStandard
instead ofDisabled
Scenario 3:
Block all cookies
Block all fingerprinting
Cookies blocking
is set toAll
as expectedFingerprinting blocking
is set toStandard
instead ofStrict, may break sites
Scenario 4:
Allow all cookies
Allow all fingerprinting
All cookies allowed
is shown as expected for cookies. Fingerprint settings is displayed asFingerprintblocked (standard)
instead ofAllow all fingerprinting
Actual result:
Global and site-specific shield settings are not retained correctly after upgrade to 1.11.x
1.10.x
Global shield settings
Site shiled settings
Upgrade to 1.11.x
Global shield settings for Fingerprinting should be
Disabled
instead ofStandard
Site shield settings for Fingerprinting should be
Allow all fingerprinting
instead ofFingerprinting blocked (standard)
Expected result:
Global and site-specific shield settings should be retained correctly after upgrade to 1.11.x
Reproduces how often:
Always
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
cc: @brave/legacy_qa @rebron @simonhong @karenkliu
The text was updated successfully, but these errors were encountered: