Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Global and site-specific shield settings are not retained correctly after upgrade to 1.11.x #10303

Closed
GeetaSarvadnya opened this issue Jun 16, 2020 · 3 comments

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jun 16, 2020

Description

Found while testing #9975
Global and site-specific shield settings are not retained correctly after upgrade to 1.11.x

Steps to Reproduce

Scenario 1:

  1. Clean profile 1.10.x
  2. Open brave://settings/shields
  3. Change cookies settings to Allow all cookies
  4. Change Fingerprinting settings to Allow all fingerprinting
  5. Open buzzfeed.com and verify that global shield settings are retained correctly
  6. Upgrade profile to 1.11.x
  7. Open brave://settings/shields and verify that, global shield settings for Fingerprinting should be Disabled instead of Standard as FP is allowed in step 4
  8. Open buzzfeed.com and verify that, site shield settings for Fingerprinting should be Allow all fingerprinting instead of Fingerprinting blocked (standard)

Scenario 2:

  1. Clean profile 1.10.x
  2. Open brave://settings/shields
  3. Disable global setting Block cross-site trackers
  4. Open Buzzfeed.com
  5. Verify that global settings for Block cross-site trackers are retained for buzzfeed.com (expected)
  6. Upgrade to 1.11.x
  7. Open brave://settings/shields
  8. Verify that Trackers and ad blocking is set to Standard instead of Disabled

Scenario 3:

  1. Clean profile 1.10.x
  2. Open brave://settings/shields
  3. Change cookies settings to Block all cookies
  4. Change Fingerprinting settings to Block all fingerprinting
  5. Open Buzzfeed.com
  6. Verify that global shield setting for cookies and fingerprinting are retained for buzzfeed.com (expected)
  7. Upgrade to 1.11.x
  8. Open brave://settings/shields
  9. Verify that Cookies blocking is set to All as expected
  10. Verify that Fingerprinting blocking is set to Standard instead of Strict, may break sites

Scenario 4:

  1. Clean profile 1.10.x
  2. Open buzzfeed.com
  3. Change cookies site settings to Allow all cookies
  4. Change Fingerprinting site settings to Allow all fingerprinting
  5. Upgrade to 1.11.x
  6. Visit buzzfeed.com, open shield and verify that All cookies allowed is shown as expected for cookies. Fingerprint settings is displayed as Fingerprintblocked (standard) instead of Allow all fingerprinting

Actual result:

Global and site-specific shield settings are not retained correctly after upgrade to 1.11.x
1.10.x
Global shield settings
image
Site shiled settings
image

Upgrade to 1.11.x
Global shield settings for Fingerprinting should be Disabled instead of Standard
image

Site shield settings for Fingerprinting should be Allow all fingerprinting instead of Fingerprinting blocked (standard)
image

Expected result:

Global and site-specific shield settings should be retained correctly after upgrade to 1.11.x

Reproduces how often:

Always

Brave version (brave://version info)

Brave 1.11.65 Chromium: 83.0.4103.97 (Official Build) dev (64-bit)
Revision 326d148b9655369b86498d9ecca39f63dd2bdd2d-refs/branch-heads/4103@{#657}
OS Windows 10 OS Version 1903 (Build 18362.30)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @rebron @simonhong @karenkliu

@GeetaSarvadnya GeetaSarvadnya added feature/global-settings Settings at browser level independent of shields settings feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields QA/Yes QA/Test-Plan-Specified OS/Desktop labels Jun 16, 2020
@GeetaSarvadnya GeetaSarvadnya added the feature/shields/adblock Blocking ads & trackers with Shields label Jun 17, 2020
@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Jun 18, 2020

The PR brave/brave-core#5879 may fix this issue also?
cc: @simonhong

@bridiver
Copy link
Contributor

this is not a bug, it isn intentional behavior per @pes10k

@GeetaSarvadnya
Copy link
Author

Closing the issue as per the above comments.

@GeetaSarvadnya GeetaSarvadnya removed OS/Desktop QA/Test-Plan-Specified QA/Yes feature/global-settings Settings at browser level independent of shields settings feature/shields/adblock Blocking ads & trackers with Shields feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields labels Jun 23, 2020
@GeetaSarvadnya GeetaSarvadnya removed this from the 1.12.x - Nightly milestone Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants