Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Fingerprinting 2.0: Update Fingerprinting blocked settings with 'strict' and 'standard' options #9194

Closed
pes10k opened this issue Apr 14, 2020 · 5 comments · Fixed by brave/brave-core#5684
Assignees
Labels
design A design change, especially one which needs input from the design team feature/shields The overall Shields feature in Brave. l10n OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include

Comments

@pes10k
Copy link
Contributor

pes10k commented Apr 14, 2020

This is a sub-issue of the larger font defense reorganization #8787

Designs

Shields panel
New fingerprinting dropdown menu should show:

Group 7

Panel shows:
farbling

brave://settings
shields settings4

  • Fingerprinting blocked (label: Strict, may break sites): The strongest set of protections, that disables or otherwise modifies page functionality to prevent sites from accessing or learning the underlying data needed for fingerprinting attacks. Carries larger, non-trivial web-compat risks.
  • Fingerprinting blocked (default setting and label: Standard): A useful set of protections that may not fundamentally prevent fingerprinting attacks, but re practical against real world fingerprinting attacks. Carries a small but non-zero chance of breaking sites.
  • Allow all fingerprinting (label: Disabled): Don’t apply any fingerprinting protections
@rebron rebron added feature/shields The overall Shields feature in Brave. design A design change, especially one which needs input from the design team labels Apr 20, 2020
@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes labels May 18, 2020
@karenkliu
Copy link

brave://settings designs added.

@rebron
Copy link
Collaborator

rebron commented May 27, 2020

@simonhong simonhong added this to the 1.11.x - Nightly milestone May 28, 2020
@simonhong
Copy link
Member

simonhong commented May 28, 2020

@rebron @pes10k These new option sentences should be only applied when fingerprint v2 feature is enabled? Or using from now on? => Pushed PR for using new texts from now on. :)

@pes10k
Copy link
Contributor Author

pes10k commented May 28, 2020

@simonhong At this point in nightly, I think we're well past the half way mark migrating from v1 to v2 fingerprinting defenses, and both are enabled, so I think enabling / surfacing as soon as possible in nightly would be ideal

@LaurenWags
Copy link
Member

LaurenWags commented Jul 9, 2020

Verified passed with

Brave | 1.11.92 Chromium: 84.0.4147.68 (Official Build) dev (64-bit)
-- | --
Revision | e7b7234037639b407e69c5428c891ce018cd6c0d-refs/branch-heads/4147@{#772}
OS | macOS Version 10.14.6 (Build 18G3020)

Screen Shot 2020-07-09 at 8 52 27 AM

Screen Shot 2020-07-09 at 8 52 48 AM

Screen Shot 2020-07-09 at 8 53 35 AM

Screen Shot 2020-07-09 at 8 53 47 AM


Verification passed on


Brave | 1.11.94 Chromium: 84.0.4147.85 (Official Build) (64-bit)
-- | --
Revision | e20c13e958edc3707db3d26d513780a7f6331a4b-refs/branch-heads/4147@{#837}
OS | Windows 10 OS Version 1903 (Build 18362.900)

  • Verified the design specification s from the description
    Fingerprint dropdown menus:
    image

Panel menus FP sites settings:
image
image
image

Global shield settings fro FP:
image
image
image

Shiled settings page brave://settings/shields
image


Verification passed on

Brave 1.11.92 Chromium: 84.0.4147.68 (Official Build) dev (64-bit)
Revision e7b7234037639b407e69c5428c891ce018cd6c0d-refs/branch-heads/4147@{#772}
OS Ubuntu 18.04 LTS

@rebron rebron changed the title Fingerprinting 2.0: UX / Shields Integration (update fingerprint blocking) Fingerprinting 2.0: Update Fingerprinting blocked settings with strict and standard options Jul 14, 2020
@rebron rebron changed the title Fingerprinting 2.0: Update Fingerprinting blocked settings with strict and standard options [Desktop] Fingerprinting 2.0: Update Fingerprinting blocked settings with strict and standard options Jul 14, 2020
@rebron rebron changed the title [Desktop] Fingerprinting 2.0: Update Fingerprinting blocked settings with strict and standard options [Desktop] Fingerprinting 2.0: Update Fingerprinting blocked settings with 'strict' and 'standard' options Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design A design change, especially one which needs input from the design team feature/shields The overall Shields feature in Brave. l10n OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants