Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change Fingerprinting option wording on shields panel - follow up to 7949 #9399

Closed
LaurenWags opened this issue Apr 22, 2020 · 1 comment
Closed

Comments

@LaurenWags
Copy link
Member

Description

Follow up to #7949

Per #7949 (comment) from @karenkliu, the wording for the fingerprinting options on the shields panel needs to be updated. The panel options should match those in brave://settings/shields.

Steps to Reproduce

  1. Navigate to a site
  2. Open shields panel
  3. Expand fingerprinting options

Actual result:

Screen Shot 2020-04-22 at 3 05 09 PM

Expected result:

should see these options
Screen Shot 2020-04-22 at 3 04 39 PM

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.8.82 Chromium: 81.0.4044.113 (Official Build) dev (64-bit)
Revision e3225dafb0475864a1812a374d73a92e391635ac-refs/branch-heads/4044@{#936}
OS macOS Version 10.14.6 (Build 18G3020)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the dev channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @rebron as original issue was slated for 1.8.x, unsure if this needs to be in 1.8.x as well.

@LaurenWags LaurenWags added bug needs-text-change This change requires some careful wording. feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields QA/Yes labels Apr 22, 2020
@rebron
Copy link
Collaborator

rebron commented Jun 5, 2020

Closing. Fixed with #9194

@rebron rebron closed this as completed Jun 5, 2020
@rebron rebron added closed/invalid and removed QA/Yes bug feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields needs-text-change This change requires some careful wording. labels Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants