Brave Rewards notification not reflecting processed 'Auto Contribute' amount correctly

[AndriusA]

Description

Notification in the rewards dialog does not correctly reflect the contribution just made. Rewards was set to auto-contribute 50.0 BAT and Uphold sent a notification that 50 BAT was sent.

Steps to Reproduce

1. Previous period auto-contirbution amount was set to 50.0 BAT
2. The wallet is connected to Uphold
3. Uphold email notification sent on the same date includes correct amount

Actual result:

Expected result:

The notification should show the 50.0 BAT contributed

Reproduces how often:

No steps to reproduce

Brave version (brave://version info)

Brave | 1.3.44 Chromium: 78.0.3904.108 (Official Build) nightly (64-bit)
Revision | 4b26898a39ee037623a72fcfb77279fce0e7d648-refs/branch-heads/3904@{#889}
OS | macOS Version 10.14.6 (Build 18G1012)

Version/Channel Information:

• Can you reproduce this issue with the current release? No
• Can you reproduce this issue with the beta channel? No
• Can you reproduce this issue with the dev channel? No
• Can you reproduce this issue with the nightly channel? No

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? N/A
• Does the issue resolve itself when disabling Brave Rewards? N/A
• Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

[GeetaSarvadnya]

Reproduced in Windows 10 x64 - 1.3.50 nightly build

[masparrow]

@GeetaSarvadnya @AndriusA Hi both - I just want to check the following if that's ok;

a) Do you have the Rewards panel already open when the contribution notification occurs
b) Are you are launching Brave and then opening the Rewards panel after the contribution notification
c) if a) or b) - if you quit Brave and relaunch, does Rewards show the correct contribution amount?

TIA!

[AndriusA]

Sure, though probably not very helpful:

a) no - clicked on the BAT icon because I saw an indicator showing unread notifications, dismissed another notification before seeing the one with 0 amount
b) Probably not, I think I last restarted Brave the day before, after an update
c) Not sure how to view previous notifications, this one already dismissed

[masparrow]

Thanks @AndriusA that is actually helpful - it's not a stale view of the total amount. Cheers!

[GeetaSarvadnya]

@masparrow Please find my comments inline

a) Do you have the Rewards panel already open when the contribution notification occurs - Nope, after auto contribution, I have opened the rewards panel
b) Are you are launching Brave and then opening the Rewards panel after the contribution notification - I am not relaunching the brave after the auto contribution, in the same session I am viewing the panel after the auto contribution
c) if a) or b) - if you quit Brave and relaunch, does Rewards show the correct contribution amount? - Nope, Auto contribution value remains 0.0 BAT even after the browser relaunch

[GeetaSarvadnya]

Verification passed on

Brave	1.3.97 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision	e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS	Windows 10 OS Version 1803 (Build 17134.1006)

• Verified the test plan from Brave Rewards notification not reflecting processed 'Auto Contribute' amount correctly brave-core#4133
  

• Verified auto contributed amount is displayed correctly in the ac notification in a clean profile (verified in staging env)
  

• Encountered no AC notifications in certain cases #7836 - there is no ac notification in an upgraded profile

• Verified the STR from Brave Rewards notification not reflecting processed 'Auto Contribute' amount correctly brave-core#4133 (comment)
  

• Encountered Monthly contributions (tips) and Auto Contribute are not listed on brave://rewards or panel summary #7526

Verified using

Brave	1.3.97 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision	e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS	macOS Version 10.14.6 (Build 18G103)

• Verified test plan from Brave Rewards notification not reflecting processed 'Auto Contribute' amount correctly brave-core#4133 using an anon wallet funded via UGP grant (staging)

• Verified test plan from Brave Rewards notification not reflecting processed 'Auto Contribute' amount correctly brave-core#4133 using KYC'd uphold wallet (staging). Encountered Monthly contributions (tips) and Auto Contribute are not listed on brave://rewards or panel summary #7526 (Auto Contribute not listed in summary) and also no AC notifications in certain cases #7836 (no AC notification on BAT logo)

• Verified setting up data in 1.2.43 and then upgrading the profile to 1.3.x, the AC occurs on 1.3.x. However, AC was not recorded in the summary (Monthly contributions (tips) and Auto Contribute are not listed on brave://rewards or panel summary #7526) and no notification was displayed on the BAT logo, logged no AC notifications in certain cases #7836.

Verification passed on

Brave	1.3.97 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision	e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS	Ubuntu 18.04 LTS

• Verified the test plan from Brave Rewards notification not reflecting processed 'Auto Contribute' amount correctly brave-core#4133. Anon wallet+UGP grant
  

• Verified KYCed