Monthly contributions (tips) and Auto Contribute are not listed on brave://rewards or panel summary #7526

GeetaSarvadnya · 2019-12-27T08:29:58Z

Description

Found while testing #6744
Monthly Tips are not listed under monthly contributions panel

Steps to Reproduce

Clean profile 1.3.75 staging env
Claim the UGP grants
Open https://duckduckgo.com/
Open the BR panel and set the monthly contributions for https://duckduckgo.com/
The monthly Tip isn't set and https://duckduckgo.com/ isn't displayed under monthly contributions panel.

Actual result:

Monthly Tips are not listed under monthly contributions panel

Expected result:

Monthly Tips should be listed under monthly contributions panel

Reproduces how often:

Always

Brave version (brave://version info)

Brave	1.3.75 Chromium: 79.0.3945.88 (Official Build) dev (64-bit)
Revision	c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS	Windows 10 OS Version 1803 (Build 17134.1006)

Version/Channel Information:

Can you reproduce this issue with the current release? No
Can you reproduce this issue with the beta channel? No
Can you reproduce this issue with the dev channel? Yes
Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

Does the issue resolve itself when disabling Brave Shields? NA
Does the issue resolve itself when disabling Brave Rewards? NA
Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @NejcZdovc @ryanml @rebron

btlechowski · 2020-01-04T11:30:40Z

Not reproducible on

Brave	1.3.81 Chromium: 79.0.3945.88 (Official Build) beta (64-bit)
Revision	c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS	Ubuntu 18.04 LTS

NejcZdovc · 2020-01-04T15:46:02Z

not reproduced on macOS

masparrow · 2020-01-10T14:47:38Z

@GeetaSarvadnya Hi Geeta - can I just confirm what 'DDG' is in your steps? Presuming it was 'ddg.com' I tried to reproduce the above on Windows, but it worked fine;

NejcZdovc · 2020-01-10T15:08:51Z

@masparrow ddg is https://duckduckgo.com/

masparrow · 2020-01-13T09:21:22Z

Cheers @NejcZdovc - just for completeness, I did a monthly tip for duckduckgo.com - works fine.

Nb. I was using; Version 1.5.24 Chromium: 79.0.3945.117 (Developer Build) (64-bit) (src/brave - c6d6049)

@GeetaSarvadnya Can you see if you can reproduce again, and if possible confirm if it is just Windows? Thanks!

LaurenWags · 2020-01-13T16:41:57Z

Could not reproduce on macOS using

Brave	1.3.90 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision	04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS	macOS Version 10.14.6 (Build 18G103)

@GeetaSarvadnya how did you fund your wallet? you don't specify in the steps if you restored an old wallet or claimed a staging UGP grant. not sure if that makes a difference.

GeetaSarvadnya · 2020-01-14T14:14:41Z

@LaurenWags I have funded the wallet by accepting the UGP grants. I am going to edit the STR and make steps clear. Thanks!

GeetaSarvadnya · 2020-01-14T14:28:52Z

@masparrow Issue is still reproducible. Just verified it on latest beta channel 1.3.91. Please find the gif below:

LaurenWags · 2020-01-14T15:53:53Z

Reproduced on macOS (see #7709 (comment)) using steps from #7709 (comment)

fyi @masparrow in case this additional information helps
cc @kjozwiak @rebron for consideration for the 1.3.x release

LaurenWags · 2020-01-17T21:04:10Z

Also experiencing this with one time tips using

Brave	1.3.94 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision	04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS	macOS Version 10.14.6 (Build 18G103)

My wallet balance decreases but the tip isn't shown on brave://rewards Tips panel, wallet summary, or when I click on the BAT logo to show the summary.

kjozwiak · 2020-01-21T18:11:52Z

I finally managed to reproduce this one Win 10 x64. Once I reproduced the above once on the Win 10 x64 machine, it started occurring every single time with new profiles. Example:

Attached publisher_info_db.zip which belonged to this particular profile.

Reproduced the above issue using the following build:

Brave	1.3.97 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision	e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS	Windows 10 OS Version 1909 (Build 18363.592)

However, I'm still having a hard time reproducing this on macOS but sounds like @LaurenWags ran into it via #7526 (comment).

masparrow · 2020-01-22T11:46:55Z

Verified as fixed by the PR brave/brave-core#4372 - @LaurenWags recommend this is regression tested against that PR (or nightly once that PR is merged).

LaurenWags · 2020-01-23T23:04:39Z

Retested on Nightly extensively while checking brave/brave-core#4399 (comment) and brave/brave-core#4372 (comment) and could not reproduce. Moving to 1.3.x milestone to be retested after these PRs are uplifted. Adding QA/Blocked label for now as well.

Brave	1.5.53 Chromium: 79.0.3945.130 (Official Build) nightly (64-bit)
Revision	e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS	macOS Version 10.14.6 (Build 18G103)

LaurenWags · 2020-01-31T22:05:11Z

Verified passed with

Brave	1.3.106 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision	e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS	macOS Version 10.14.6 (Build 18G103)

Verified 1 time tip, recurring tip, and AC using previously self-funded anon wallet:

Verified 1 time tip, recurring tip, and AC using anon wallet funded via UGP (virtual) grant:

Verified 1 time tip, recurring tip, and AC using KYC'd user wallet:

Verification passed on

Brave	1.3.107 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision	e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS	Windows 10 OS Version 1803 (Build 17134.1006)

Verified the STR from the description
Verified the test plan from Adds delays for suggestion api brave-core#4372
Logged Folllow up of #7526 - Unable to set monthly tips hence not shown under contribution panel #8019
Verified Monthly tips and one-time tips recorded in the summary and panel using wallet funded via UGP (virtual) grant:
AC went through and notification displayed as expected using user funded KYC'd wallet
Verified 1-time tip, recurring tip, and AC using KYC'd user wallet:

Verification passed on

Brave	1.3.108 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision	e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS	Ubuntu 18.04 LTS

Verified the STR from the description
Verified the test plan from Adds delays for suggestion api brave-core#4372
Verified Monthly tips and one-time tips recorded in the summary and panel using wallet funded via UGP (virtual) grant:
Verified 1-time tip, recurring tip, and AC using KYC'd user wallet:

GeetaSarvadnya added bug feature/rewards QA/Yes QA/Test-Plan-Specified regression labels Dec 27, 2019

GeetaSarvadnya mentioned this issue Dec 27, 2019

Thank you banner for monthly contribution #6744

Closed

NejcZdovc self-assigned this Dec 27, 2019

NejcZdovc assigned masparrow and unassigned NejcZdovc Jan 4, 2020

NejcZdovc added the OS/Windows label Jan 4, 2020

masparrow assigned GeetaSarvadnya and unassigned masparrow Jan 13, 2020

NejcZdovc mentioned this issue Jan 14, 2020

entire a-c not going through due to missing delays #7709

Closed

LaurenWags changed the title ~~Monthly contributions are not listed under monthly contributions panel~~ Monthly contributions (tips) and Auto Contribute are not listed under monthly contributions panel Jan 14, 2020

LaurenWags removed the OS/Windows label Jan 14, 2020

LaurenWags changed the title ~~Monthly contributions (tips) and Auto Contribute are not listed under monthly contributions panel~~ Monthly contributions (tips) and Auto Contribute are not listed on brave://rewards Jan 14, 2020

LaurenWags changed the title ~~Monthly contributions (tips) and Auto Contribute are not listed on brave://rewards~~ Monthly contributions (tips) and Auto Contribute are not listed on brave://rewards or panel summary Jan 14, 2020

masparrow assigned masparrow and unassigned GeetaSarvadnya Jan 14, 2020

kjozwiak mentioned this issue Jan 17, 2020

Configurable default tip amounts #6011

Closed

LaurenWags mentioned this issue Jan 17, 2020

Refactor loadFromJson from RapidJSON to base::JSONReader #6351

Closed

GeetaSarvadnya mentioned this issue Jan 21, 2020

Brave Rewards notification not reflecting processed 'Auto Contribute' amount correctly #7185

Closed

This was referenced Jan 21, 2020

AC with virtual grants flow with uphold funds #7595

Closed

no AC notifications in certain cases #7836

Closed

LaurenWags mentioned this issue Jan 22, 2020

Expand contributon_info table #6942

Closed

LaurenWags added release-notes/exclude QA/Blocked labels Jan 23, 2020

LaurenWags added this to the 1.3.x - Beta milestone Jan 23, 2020

LaurenWags closed this as completed Jan 23, 2020

LaurenWags removed the QA/Blocked label Jan 30, 2020

LaurenWags added the QA Pass-macOS label Jan 31, 2020

GeetaSarvadnya mentioned this issue Feb 3, 2020

Folllow up of #7526 - Unable to set monthly tips hence not shown under contribution panel #8019

Closed

GeetaSarvadnya added the QA Pass-Win64 label Feb 3, 2020

btlechowski added the QA Pass-Linux label Feb 3, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Monthly contributions (tips) and Auto Contribute are not listed on brave://rewards or panel summary #7526

Monthly contributions (tips) and Auto Contribute are not listed on brave://rewards or panel summary #7526

GeetaSarvadnya commented Dec 27, 2019 •

edited

Loading

btlechowski commented Jan 4, 2020

NejcZdovc commented Jan 4, 2020

masparrow commented Jan 10, 2020

NejcZdovc commented Jan 10, 2020

masparrow commented Jan 13, 2020 •

edited

Loading

LaurenWags commented Jan 13, 2020

GeetaSarvadnya commented Jan 14, 2020 •

edited

Loading

GeetaSarvadnya commented Jan 14, 2020

LaurenWags commented Jan 14, 2020

LaurenWags commented Jan 17, 2020

kjozwiak commented Jan 21, 2020

masparrow commented Jan 22, 2020

LaurenWags commented Jan 23, 2020

LaurenWags commented Jan 31, 2020 •

edited by btlechowski

Loading

Monthly contributions (tips) and Auto Contribute are not listed on brave://rewards or panel summary #7526

Monthly contributions (tips) and Auto Contribute are not listed on brave://rewards or panel summary #7526

Comments

GeetaSarvadnya commented Dec 27, 2019 • edited Loading

Description

Steps to Reproduce

Actual result:

Expected result:

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

Other Additional Information:

Miscellaneous Information:

btlechowski commented Jan 4, 2020

NejcZdovc commented Jan 4, 2020

masparrow commented Jan 10, 2020

NejcZdovc commented Jan 10, 2020

masparrow commented Jan 13, 2020 • edited Loading

LaurenWags commented Jan 13, 2020

GeetaSarvadnya commented Jan 14, 2020 • edited Loading

GeetaSarvadnya commented Jan 14, 2020

LaurenWags commented Jan 14, 2020

LaurenWags commented Jan 17, 2020

kjozwiak commented Jan 21, 2020

masparrow commented Jan 22, 2020

LaurenWags commented Jan 23, 2020

LaurenWags commented Jan 31, 2020 • edited by btlechowski Loading

GeetaSarvadnya commented Dec 27, 2019 •

edited

Loading

masparrow commented Jan 13, 2020 •

edited

Loading

GeetaSarvadnya commented Jan 14, 2020 •

edited

Loading

LaurenWags commented Jan 31, 2020 •

edited by btlechowski

Loading