Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thank you banner for monthly contribution #6744

Closed
NejcZdovc opened this issue Nov 4, 2019 · 2 comments · Fixed by brave/brave-core#3998
Closed

Thank you banner for monthly contribution #6744

NejcZdovc opened this issue Nov 4, 2019 · 2 comments · Fixed by brave/brave-core#3998
Assignees
@ryanml
Labels
feature/rewards priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
1.3.x - Release

Comments

@NejcZdovc
Copy link
Contributor

Follow up from #6151

Currently we display this fo monthly contribution

We should display different text.

cc @alexwykoff @davidtemkin @jenn-rhim please provide resolution for it
@NejcZdovc NejcZdovc added the priority/P2 A bad problem. We might uplift this to the next planned release. label Nov 11, 2019
@NejcZdovc NejcZdovc added the design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. label Nov 11, 2019
@jenn-rhim
Copy link

jenn-rhim commented Nov 11, 2019 •
edited
Loading

the wording needs to reflect 'monthly contribution', which is scheduled for being sent on the same contribution date with the amount the user designated. See below. @NejcZdovc @ryanml

mc-confirmation

@NejcZdovc NejcZdovc assigned ryanml and unassigned alexwykoff and jenn-rhim Nov 13, 2019
@ryanml ryanml removed the design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. label Nov 14, 2019
ryanml added a commit to brave/brave-core that referenced this issue Nov 14, 2019
@ryanml
Adds contribution info to tipping banner
f3d352a 
Fixes brave/brave-browser#6744
@ryanml ryanml mentioned this issue Nov 14, 2019
Merged
32 tasks
ryanml added a commit to brave/brave-core that referenced this issue Nov 15, 2019
@ryanml
Adds contribution info to tipping banner
d384968 
Fixes brave/brave-browser#6744
@NejcZdovc NejcZdovc added this to the 1.3.x - Nightly milestone Nov 18, 2019
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Dec 27, 2019 •
edited by kjozwiak
Loading

Verification passed on

Brave 1.3.75 Chromium: 79.0.3945.88 (Official Build) dev (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Verification passed on

Brave 1.3.81 Chromium: 79.0.3945.88 (Official Build) beta (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS Ubuntu 18.04 LTS

image
image

image
image

Verification PASSED on macOS 10.15.2 x64 using the following build:

Brave 1.3.91 Chromium: 79.0.3945.117 (Official Build) beta (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS macOS Version 10.15.2 (Build 19C57)

Screen Shot 2020-01-14 at 5 35 35 PM

Screen Shot 2020-01-14 at 5 35 00 PM

This was referenced Dec 27, 2019
Closed
Closed
@LaurenWags LaurenWags mentioned this issue Feb 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryanml ryanml

Labels
feature/rewards priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Milestone
1.3.x - Release
Development

Successfully merging a pull request may close this issue.

Adds contribution info to tipping banner brave/brave-core
8 participants
@alexwykoff @kjozwiak @jenn-rhim @ryanml @NejcZdovc @LaurenWags @btlechowski @GeetaSarvadnya