-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve our copyright statement #6605
Comments
@tomlowenthal Could you please review this proposed copy: |
This add a link to the license, build instructions as well as the corresponding source code.
🚢 ship it. |
This add a link to the license, build instructions as well as the corresponding source code.
This add a link to the license, build instructions as well as the corresponding source code.
This add a link to the license, build instructions as well as the corresponding source code.
This add a link to the license, build instructions as well as the corresponding source code.
Verification passed on
|
@fmarier Copyright statement is slightly different, In #6605 (comment) |
Assuming |
I don't think that Brave Software Inc. is right here. We didn't actually write the whole thing. |
@tomlowenthal can you create a follow up issue with the correct wording that needs to be used? We usually don't use the same issue and associate multiple PR/fixes to minimize confusion. |
Thanks @tomlowenthal. Created #6883 so we can unblock QA and address the issue in another release. |
Verification PASSED on
Example: Verification passed on
Verification passed on
|
Our existing license notice (in
chrome://settings/help
):neither mentions the fact that Brave is under the MPL nor links to the license.
For comparison, here's how Firefox does it (in
about:license
):Ideally, we should link to the exact version tag on GitHub instead of linking just to
https://github.com/brave/brave-browser
.Related improvements to the same page: #4990, #6152
The text was updated successfully, but these errors were encountered: