Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve our copyright statement #6605

Closed
fmarier opened this issue Oct 25, 2019 · 10 comments
Closed

Improve our copyright statement #6605

fmarier opened this issue Oct 25, 2019 · 10 comments
Assignees
Labels
licensing policy This is a policy choice, relates to terms & conditions, or has a legal element to it. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude

Comments

@fmarier
Copy link
Member

fmarier commented Oct 25, 2019

Our existing license notice (in chrome://settings/help):
67339412-10031580-f4e0-11e9-9f36-65939450e4fd

neither mentions the fact that Brave is under the MPL nor links to the license.

For comparison, here's how Firefox does it (in about:license):
67339499-33c65b80-f4e0-11e9-91df-f04b600c9a0e

Ideally, we should link to the exact version tag on GitHub instead of linking just to https://github.com/brave/brave-browser.

Related improvements to the same page: #4990, #6152

@fmarier fmarier self-assigned this Oct 25, 2019
@fmarier
Copy link
Member Author

fmarier commented Oct 25, 2019

@tomlowenthal Could you please review this proposed copy:
screenshot_from_2019-10-23_14-43-09

fmarier added a commit to brave/brave-core that referenced this issue Oct 25, 2019
This add a link to the license, build instructions as well as the
corresponding source code.
@tildelowengrimm
Copy link
Contributor

🚢 ship it.

@rebron rebron added the policy This is a policy choice, relates to terms & conditions, or has a legal element to it. label Oct 29, 2019
fmarier added a commit to brave/brave-core that referenced this issue Oct 31, 2019
This add a link to the license, build instructions as well as the
corresponding source code.
@rebron rebron added the 1.0 label Nov 5, 2019
@fmarier fmarier added this to the 0.74.x - Nightly milestone Nov 5, 2019
fmarier added a commit to brave/brave-core that referenced this issue Nov 9, 2019
This add a link to the license, build instructions as well as the
corresponding source code.
fmarier added a commit to brave/brave-core that referenced this issue Nov 9, 2019
This add a link to the license, build instructions as well as the
corresponding source code.
fmarier added a commit to brave/brave-core that referenced this issue Nov 9, 2019
This add a link to the license, build instructions as well as the
corresponding source code.
@GeetaSarvadnya
Copy link

Verification passed on

Brave 0.71.114 Chromium: 78.0.3904.97 (Official Build) (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS Windows 10 OS Version 1803 (Build 17134.1006)

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Nov 11, 2019

@fmarier Copyright statement is slightly different, In #6605 (comment) The Brave Authors is mentioned but in 0.71.114 it's replaced by Brave Software Inc, which one is correct, could you please confirm?

@kjozwiak
Copy link
Member

Assuming Brave Software Inc is the correct one as using The Brave Authors wouldn't make sense in a copyright sentence IMO. I'll let @fmarier comment though 👍

@tildelowengrimm
Copy link
Contributor

I don't think that Brave Software Inc. is right here. We didn't actually write the whole thing.

@kjozwiak
Copy link
Member

@tomlowenthal can you create a follow up issue with the correct wording that needs to be used? We usually don't use the same issue and associate multiple PR/fixes to minimize confusion.

@tildelowengrimm
Copy link
Contributor

@kjozwiak I'm not proposing a change. I'm just suggesting that the fix should match what @fmarier wrote above.

@kjozwiak
Copy link
Member

@kjozwiak I'm not proposing a change. I'm just suggesting that the fix should match what @fmarier wrote above.

Thanks @tomlowenthal. Created #6883 so we can unblock QA and address the issue in another release.

@kjozwiak
Copy link
Member

kjozwiak commented Nov 12, 2019

Verification PASSED on macOS 10.15.1 x64 using the following build:

Brave 0.71.114 Chromium: 78.0.3904.97 (Official Build) (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS macOS Version 10.15.1 (Build 19B88)

Example:

Screen Shot 2019-11-11 at 9 30 25 PM

Verification passed on

Brave 0.71.114 Chromium: 78.0.3904.97 (Official Build) (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Verification passed on

Brave 0.71.114 Chromium: 78.0.3904.97 (Official Build) (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS Ubuntu 18.04 LTS

image
image
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
licensing policy This is a policy choice, relates to terms & conditions, or has a legal element to it. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Development

No branches or pull requests

7 participants