Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add copyright (c) symbol in About Brave #4990

Closed
rebron opened this issue Jun 19, 2019 · 7 comments · Fixed by #6771 or brave/brave-core#3881
Closed

Add copyright (c) symbol in About Brave #4990

rebron opened this issue Jun 19, 2019 · 7 comments · Fixed by #6771 or brave/brave-core#3881

Comments

@rebron
Copy link
Collaborator

rebron commented Jun 19, 2019

Test plan

See brave/brave-core#3881

Description

Change current: Copyright 2019 Brave Software Inc. All rights reserved.
To new: Copyright © 2019 Brave Software Inc. All rights reserved.

Screenshot of Issue

image

@rebron
Copy link
Collaborator Author

rebron commented Jun 19, 2019

cc: @bradleyrichter

@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jun 19, 2019
@fmarier fmarier self-assigned this Oct 23, 2019
@fmarier
Copy link
Member

fmarier commented Oct 23, 2019

Same missing (C) in brave://version:
Screenshot from 2019-10-23 14-19-54

fmarier added a commit to brave/brave-core that referenced this issue Oct 24, 2019
fmarier added a commit to brave/brave-core that referenced this issue Oct 30, 2019
This also fixes a "Brave LLC" string in the copyright notice.
fmarier added a commit that referenced this issue Oct 30, 2019
This also fixes a "Brave LLC" string in the copyright notice.
fmarier added a commit that referenced this issue Oct 30, 2019
This also fixes a "Brave LLC" string in the copyright notice.
fmarier added a commit to brave/brave-core that referenced this issue Oct 30, 2019
This also fixes a "Brave LLC" string in the copyright notice.
@bsclifton bsclifton added this to the 0.73.x - Nightly milestone Oct 30, 2019
fmarier added a commit that referenced this issue Nov 1, 2019
This adds a copyright symbol (C) to the copyright statement
in chrome://settings/help.

This also fixes a "Brave LLC" string in the copyright notice.
fmarier added a commit that referenced this issue Nov 1, 2019
This adds a copyright symbol (C) to the copyright statement
in chrome://settings/help.

This also fixes a "Brave LLC" string in the copyright notice.
fmarier added a commit that referenced this issue Nov 5, 2019
This also fixes a "Brave LLC" string in the copyright notice.
fmarier added a commit to brave/brave-core that referenced this issue Nov 5, 2019
This also fixes a "Brave LLC" string in the copyright notice.
@petemill
Copy link
Member

petemill commented Nov 5, 2019

Can I ask why this is a requirement and worth diverting from Chromium on? Copyright law seems to say that you either need the word Copyright or the copyright symbol ©. The fix we have more than likely works, but there's always risk for symbols not working in certain scenarios and I'm not sure what the point is cc @rebron

@bradleyrichter
Copy link

@petemill

Chrome is the first app I have ever seen that doesn't include the © symbol. Normally apps include both, or only the © symbol.

But if adding in this common symbol to the string takes a lot more time that it took me to snap these screen shots, then don't bother. We can be unique like Chrome. ; )

image

@tildelowengrimm
Copy link
Contributor

I'm not a lawyer. Copyright law doesn't require any statement whatsoever: you don't need the word "Copyright", you don't need "©". Anything fixed in a tangible medium of expression is covered, and that includes all software. This is a cosmetic and æsthetic change, not a legal one.

@bradleyrichter
Copy link

Agree 100%. It's purely cosmetic. Like changing a blue button to orange. ; )

fmarier added a commit that referenced this issue Nov 14, 2019
This also fixes a "Brave LLC" string in the copyright notice.
fmarier added a commit to brave/brave-core that referenced this issue Nov 14, 2019
This also fixes a "Brave LLC" string in the copyright notice.
fmarier added a commit that referenced this issue Nov 14, 2019
This also fixes a "Brave LLC" string in the copyright notice.
fmarier added a commit that referenced this issue Nov 14, 2019
This also fixes a "Brave LLC" string in the copyright notice.
fmarier added a commit to brave/brave-core that referenced this issue Nov 14, 2019
This also fixes a "Brave LLC" string in the copyright notice.
fmarier added a commit that referenced this issue Nov 15, 2019
This also fixes a "Brave LLC" string in the copyright notice.
fmarier added a commit that referenced this issue Nov 15, 2019
This also fixes a "Brave LLC" string in the copyright notice.
fmarier added a commit to brave/brave-core that referenced this issue Nov 21, 2019
This also fixes a "Brave LLC" string in the copyright notice.
@fmarier fmarier modified the milestones: 1.2.x - Dev, 1.3.x - Nightly Nov 25, 2019
@btlechowski
Copy link

btlechowski commented Nov 28, 2019

Verification passed on

Brave 1.3.38 Chromium: 78.0.3904.108 (Official Build) nightly (64-bit)
Revision 4b26898a39ee037623a72fcfb77279fce0e7d648-refs/branch-heads/3904@{#889}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#3881

image

Verification passed on

Brave 1.3.75 Chromium: 79.0.3945.88 (Official Build) dev (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS Windows 10 OS Version 1803 (Build 17134.1006)

image

Verified passed with

Brave 1.3.85 Chromium: 79.0.3945.88 (Official Build) beta (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS macOS Version 10.14.6 (Build 18G103)

Screen Shot 2020-01-07 at 11 42 02 AM

Screen Shot 2020-01-07 at 11 46 45 AM

petemill pushed a commit to brave/brave-core that referenced this issue Jul 27, 2020
This also fixes a "Brave LLC" string in the copyright notice.
petemill pushed a commit to brave/brave-core that referenced this issue Jul 28, 2020
This also fixes a "Brave LLC" string in the copyright notice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment