Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing copyright symbol #3788

Closed
wants to merge 1 commit into from

Conversation

fmarier
Copy link
Member

@fmarier fmarier commented Oct 23, 2019

Fixes brave/brave-browser#4990.

Submitter Checklist:

Test Plan:

Open brave://settings/help and brave://version and confirm that the (C) symbol is present.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@fmarier fmarier self-assigned this Oct 23, 2019
@fmarier fmarier force-pushed the francois-missing-copyright-symbol-4990 branch from 8e4e7c2 to 978456e Compare October 24, 2019 01:37
@fmarier fmarier changed the title Add missing copyright symbol (fixes brave/brave-browser#4990) Add missing copyright symbol Oct 24, 2019
@fmarier fmarier requested a review from bbondy October 24, 2019 21:28
@fmarier fmarier added this to the 0.73.x - Nightly milestone Oct 24, 2019
Copy link
Member

@bbondy bbondy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually sorry this won't work because this file is auto-generated and copied from Chromium on each rebase. I think we'd have to do a dynamic modification instead, possibly inside brave-browser's lib/l10nUtil.js or script/chromium-rebase-l10n.py

@fmarier fmarier closed this Oct 29, 2019
@fmarier fmarier deleted the francois-missing-copyright-symbol-4990 branch October 29, 2019 23:04
@fmarier
Copy link
Member Author

fmarier commented Oct 29, 2019

Moved to brave/brave-browser#6655.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add copyright (c) symbol in About Brave
2 participants