Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Brave Software Inc" shouldn't be used for copyright via "chrome://settings/help" (Windows/Mac) #6883

Closed
kjozwiak opened this issue Nov 12, 2019 · 5 comments

Comments

@kjozwiak
Copy link
Member

Description

As per @tomlowenthal via #6605 (comment), the current copyright statement is incorrect and needs to be changed. The original issue mentions The Brave Authors but we're using Brave Software Inc.

@tomlowenthal please provide the correct string/text.

Steps to Reproduce

  1. launch brave (used 0.71.114 CR: 78.0.3904.97 in this instance)
  2. load chrome://settings/help

Actual result:

Screen Shot 2019-11-11 at 9 21 11 PM

Expected result:

@tomlowenthal please provide the correct string/text.

Reproduces how often:

100% reproducible using the above STR.

Brave version (brave://version info)

Brave 0.71.114 Chromium: 78.0.3904.97 (Official Build) (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS macOS Version 10.15.1 (Build 19B88)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

CCing @brave/legacy_qa @tomlowenthal @bsclifton @rebron @fmarier

@fmarier
Copy link
Member

fmarier commented Nov 13, 2019

Interesting, it shows up as Brave Authors on Linux:
Screenshot from 2019-11-13 11-42-24

Also that part of the copyright box wasn't actually changed in brave/brave-core#3828 so I'm guessing it's always been like this (and different on Mac v. Linux?).

@fmarier
Copy link
Member

fmarier commented Nov 13, 2019

Windows shows "Brave Software" like Mac:
Screenshot from 2019-11-13 13-18-03

@fmarier fmarier changed the title "Brave Software Inc" shouldn't be used for copyright via "chrome://settings/help" "Brave Software Inc" shouldn't be used for copyright via "chrome://settings/help" (Windows/Mac) Nov 13, 2019
@yrliou
Copy link
Member

yrliou commented Nov 13, 2019

FYI I would think it was replaced by this line, and has been around for quite some time: https://github.com/brave/brave-browser/blob/master/lib/l10nUtil.js#L163, but not sure why it's not the case on Linux.

@fmarier
Copy link
Member

fmarier commented Nov 13, 2019

I'll include a fix for that as part of #6771 / brave/brave-core#3881.

@btlechowski
Copy link

btlechowski commented Nov 28, 2019

Verification passed on

Brave 1.3.38 Chromium: 78.0.3904.108 (Official Build) nightly (64-bit)
Revision 4b26898a39ee037623a72fcfb77279fce0e7d648-refs/branch-heads/3904@{#889}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#3881

image

Verification passed on

Brave 1.3.75 Chromium: 79.0.3945.88 (Official Build) dev (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Verified passed with

Brave 1.3.85 Chromium: 79.0.3945.88 (Official Build) beta (64-bit)
Revision c2a58a36b9411c80829b4b154bfcab97e581f1f3-refs/branch-heads/3945@{#954}
OS macOS Version 10.14.6 (Build 18G103)

Screen Shot 2020-01-07 at 11 42 02 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment