-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Brave Software Inc" shouldn't be used for copyright via "chrome://settings/help" (Windows/Mac) #6883
Comments
Interesting, it shows up as Brave Authors on Linux: Also that part of the copyright box wasn't actually changed in brave/brave-core#3828 so I'm guessing it's always been like this (and different on Mac v. Linux?). |
FYI I would think it was replaced by this line, and has been around for quite some time: https://github.com/brave/brave-browser/blob/master/lib/l10nUtil.js#L163, but not sure why it's not the case on Linux. |
I'll include a fix for that as part of #6771 / brave/brave-core#3881. |
Verification passed on
Verified test plan from brave/brave-core#3881 Verification passed on
Verified passed with
|
Description
As per @tomlowenthal via #6605 (comment), the current copyright statement is incorrect and needs to be changed. The original issue mentions
The Brave Authors
but we're usingBrave Software Inc
.@tomlowenthal please provide the correct string/text.
Steps to Reproduce
0.71.114 CR: 78.0.3904.97
in this instance)chrome://settings/help
Actual result:
Expected result:
@tomlowenthal please provide the correct string/text.
Reproduces how often:
100% reproducible using the above STR.
Brave version (brave://version info)
Version/Channel Information:
Yes
Yes
Yes
Yes
Other Additional Information:
N/A
N/A
N/A
Miscellaneous Information:
CCing @brave/legacy_qa @tomlowenthal @bsclifton @rebron @fmarier
The text was updated successfully, but these errors were encountered: