Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show background image should be default on #4995

Closed
rebron opened this issue Jun 20, 2019 · 3 comments · Fixed by brave/brave-core#2756
Closed

show background image should be default on #4995

rebron opened this issue Jun 20, 2019 · 3 comments · Fixed by brave/brave-core#2756

Comments

@rebron
Copy link
Collaborator

rebron commented Jun 20, 2019

Test plan

  1. New profile/user. New tab page background images should be on by default.
  2. Existing user 67 and lower. Upgrade to 68, New tab page background should have images.

Description

With fix for #4523, background images is defaulted off.

Background images should be shown by default.

It's a jarring change for existing users, who had background images previously.

Will need to test on upgrade that user preference is maintained.

  1. If user selects background images off, on upgrade, background images should still be off.
  2. If user selects background images on (default state but if users toggle back to background images on after previously selecting background images off), background images should still be on.

current screen for new users and existing user's updating

Screen Shot 2019-06-19 at 10 17 41 PM

expected screen for new users and existing user's updating (but with their stats/top tiles info intact)

Screen Shot 2019-06-19 at 10 20 50 PM

@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Jun 20, 2019
@srirambv
Copy link
Contributor

The new setting to disable background image isn't intuitive and can be easily missed. @karenkliu how about adding a one time focus with tooltip is shown on opening a new tab after the fix goes into the release?

@karenkliu
Copy link

@srirambv Originally I wanted the panel to actually be open the first time a user landed on the page, but @bradleyrichter decided it's better to let user discovery take its course.

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jul 30, 2019

Verification passed on

Brave 0.68.113 Chromium: 76.0.3809.62 (Official Build) beta (64-bit)
Revision 7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS Windows 10 OS Version 1803 (Build 17134.523)

image

Verification passed on

Brave 0.68.113 Chromium: 76.0.3809.62 (Official Build) beta (64-bit)
Revision 7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS Ubuntu 18.04 LTS

Verified passed with

Brave 0.68.116 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Mac OS X
  • Verified test plan from description:
    • Clean profile with 0.68.116. Verified NTP had setting for background images ON.
    • Installed 0.67.112. Upgraded to 0.68.116. Verified NTP had setting for background images ON.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants