Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make background image on NTP default enabled #2756

Merged
merged 1 commit into from
Jun 21, 2019
Merged

make background image on NTP default enabled #2756

merged 1 commit into from
Jun 21, 2019

Conversation

cezaraugusto
Copy link
Contributor

close brave/brave-browser#4995

Submitter Checklist:

Test Plan:

New tab page background images should be default on

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

imptrx
imptrx previously approved these changes Jun 20, 2019
Copy link
Contributor

@imptrx imptrx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - pending Jenkins for merge

@imptrx
Copy link
Contributor

imptrx commented Jun 20, 2019

jenkins isn't happy - rebasing

@imptrx imptrx merged commit 3aff9d1 into master Jun 21, 2019
@imptrx imptrx deleted the ca-4995 branch June 21, 2019 00:14
@bsclifton bsclifton added this to the 0.68.x - Nightly milestone Jun 23, 2019
@bsclifton
Copy link
Member

Set milestone for both issue and PR as 0.68.x (it was missing on both). Also, updated labels (QA/Yes, etc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

show background image should be default on
3 participants