Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise black focus outlines in welcome experience #4658

Closed
rossmoody opened this issue May 31, 2019 · 3 comments · Fixed by brave/brave-core#2605
Closed

Revise black focus outlines in welcome experience #4658

rossmoody opened this issue May 31, 2019 · 3 comments · Fixed by brave/brave-core#2605

Comments

@rossmoody
Copy link
Contributor

Need to revise the focus styling in the welcome experience away from the thick black squares.

image

@bsclifton
Copy link
Member

Related / dupe of #3633

@kjozwiak
Copy link
Member

kjozwiak commented Aug 2, 2019

@rossmoody can you please add a screenshot/example of how the new focus lines should appear under brave://welcome. This way QA will be able to tell if what we're seeing is actually the expected/intended behaviour 👍

Are the focus lines changes anywhere else, or this strictly for the brave://welcome page?

@btlechowski
Copy link

Verification passed on

Brave 0.68.128 Chromium: 76.0.3809.100 (Official Build) beta (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Ubuntu 18.04 LTS

The ugly focus outline is gone. Checked all welcome sub-pages.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants