This repository has been archived by the owner on May 13, 2024. It is now read-only.
Button focus styling #486
Merged
Button focus styling #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This one will need some updates on the core side as well. I started a branch but was having build issues. @cezaraugusto want me to do the core or or you got it? |
|
could you try again using current latest? if error persist feel free to DM and we can go over together |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses brave/brave-browser#4658
This one is just a revision of the black focus squares we have going on in the default buttons at the moment. This can be reverted when the shared button component is more thoroughly defined.
These changes will have to happen in large part (I believe) in Core repo. The styling approach took into consideration the theming update in the neighboring PR.