Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus ring on buttons looks odd #3633

Closed
srirambv opened this issue Mar 8, 2019 · 3 comments · Fixed by brave/brave-core#2778
Closed

Focus ring on buttons looks odd #3633

srirambv opened this issue Mar 8, 2019 · 3 comments · Fixed by brave/brave-core#2778
Assignees
Labels
design A design change, especially one which needs input from the design team feature/user-interface All UI related polish Nice to have — usually related to front-end/visual tasks priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude

Comments

@srirambv
Copy link
Contributor

srirambv commented Mar 8, 2019

Description

Focus ring on buttons look odd

Actual result:

image

Expected result:

No orange rectangular border should be shown around the button

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.63.1 Chromium: 73.0.3683.67 (Official Build) dev (64-bit)
Revision a83fd4f3207ae83412d329a9ca1239dd1e068345-refs/branch-heads/3683@{#760}
OS Windows 10 OS Build 17134.590

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    Yes only on dev

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

cc: @cezaraugusto @rossmoody

@srirambv srirambv added feature/user-interface All UI related polish Nice to have — usually related to front-end/visual tasks design A design change, especially one which needs input from the design team QA/Yes release-notes/exclude labels Mar 8, 2019
@rebron rebron added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Mar 15, 2019
@cezaraugusto
Copy link
Contributor

cc @petemill

@rossmoody
Copy link
Contributor

An updated spec for button styling can be reviewed here: https://share.goabstract.com/22f7c7af-fa47-404f-aeca-b896f0c58b4b

@LaurenWags
Copy link
Member

LaurenWags commented Aug 29, 2019

Verified passed with

Brave 0.69.119 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Mac OS X

Verification passed on

Brave 0.69.119 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Linux

image

Verification passed on

Brave 0.69.119 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Windows 7 Service Pack 1 (Build 7601.24494)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design A design change, especially one which needs input from the design team feature/user-interface All UI related polish Nice to have — usually related to front-end/visual tasks priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants